Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form state doesn't update correctly when using ChangeDetectionStrategy.OnPush #311

Closed
madmurl0c opened this issue Aug 2, 2022 · 4 comments
Labels
bug Something isn't working GitHub

Comments

@madmurl0c
Copy link

What is the current behaviour
When editing text in tinymce the form state doesn't update correctly.

How to reproduce

  1. Open https://stackblitz.com/edit/angular-13-rmvnj2
  2. Type in tinymce (state is not updated)
  3. Type in regular input (state updates correctly)

Expected behaviuor
The form state should update automatically like it does with the regular input element.

@exalate-issue-sync
Copy link

Ref: INT-2974

@danobri
Copy link

danobri commented Nov 3, 2022

Any updates on this? I got tripped up by the same issue. For anyone interested, to avoid removing ChangeDetectionStrategy.OnPush, wiring up the onSelectionChange event seems to force change detection.

<editor formControlName="comment" (onSelectionChange)="undefined"></editor>

@danoaky-tiny danoaky-tiny added the bug Something isn't working label Jan 12, 2024
@JustDoItSascha
Copy link

When will this be merged?

@danoaky-tiny
Copy link
Contributor

Fixed in latest release (v8), closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GitHub
Projects
None yet
Development

No branches or pull requests

4 participants