Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint and fix eslint issues #55

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Add eslint and fix eslint issues #55

merged 3 commits into from
Jul 25, 2022

Conversation

jetersen
Copy link
Contributor

fixes #46

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the chore label Jul 25, 2022
@timja
Copy link
Owner

timja commented Jul 25, 2022

lint issues

timja
timja reviewed Jul 25, 2022
View reviewed changes
package.json
"lint": "prettier --check .",
"lint:fix": "prettier --write ."
"lint": "eslint .",
"lint:fix": "eslint --fix ."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make it so you don't need to invoke prettier at all? i.e. the plugin will do prettier under the hood?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however this only applies to js files 😅

So potentially you want it for other files

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57

@timja
Copy link
Owner

timja commented Jul 25, 2022

Thanks!

@timja timja changed the title add eslint and fix eslint issues Add eslint and fix eslint issues Jul 25, 2022
@timja timja merged commit 00fbd39 into timja:main Jul 25, 2022
@jetersen jetersen deleted the add/eslint branch July 25, 2022 09:58
@timja timja mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemeurherve lemeurherve lemeurherve left review comments

@timja timja timja left review comments

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eslint
3 participants
@jetersen @timja @lemeurherve