Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May need to re-add prettier for non-js files #57

Closed
timja opened this issue Jul 25, 2022 · 3 comments
Closed

May need to re-add prettier for non-js files #57

timja opened this issue Jul 25, 2022 · 3 comments

Comments

@timja
Copy link
Owner

timja commented Jul 25, 2022

however this only applies to js files 😅

So potentially you want it for other files

Originally posted by @jetersen in #55 (comment)

@jetersen
Copy link
Contributor

jetersen commented Jul 25, 2022

instead of pre-commit, you could use lint-staged. Which solves the same problem for linters, see my use case here:

I use husky to trigger lint-staged

@timja
Copy link
Owner Author

timja commented Jul 25, 2022

instead of pre-commit, you could use lint-staged. Which solves the same problem for linters, see my use case here:

I use husky to trigger lint-staged

I used that previously but I also wanted helm-docs ran as part of the lint.

If lint-staged can be made to work with that as well then that's fine.

https://github.com/timja/github-comment-ops/blob/main/.pre-commit-config.yaml#L2-L5

@timja
Copy link
Owner Author

timja commented Jul 29, 2022

Fixed in #60

@timja timja closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants