Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality for working around Julia issue #26314: wrong path for stdlib methods #16

Merged
merged 3 commits into from
Mar 15, 2019

Conversation

KristofferC
Copy link
Collaborator

No description provided.

@KristofferC KristofferC changed the title add functionality for working around Julia issue #26314 add functionality for working around Julia issue #26314: wrong path for stdlib methods Mar 15, 2019
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #16   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         110   115    +5     
====================================
- Misses        110   115    +5
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f081a...cac3c53. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #16   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         113   118    +5     
====================================
- Misses        113   118    +5
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8002646...0ac1c73. Read the comment docs.


m = first(methods(Test.eval))
@test occursin(Sys.STDLIB, whereis(m)[1])

# Test with broken lookup
CodeTracking.method_lookup_callback[] = m -> error("oops")
@test whereis(m) == ("REPL[1]", 1)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code from the merge below needs to be moved above my addition?

@timholy timholy merged commit f3963c3 into timholy:master Mar 15, 2019
@KristofferC KristofferC deleted the kc/stdlib_buildbot branch March 15, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants