Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around problem with finding stdlib files #146

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 14, 2019

Commited on top of #145

Previously we couldnt see the source for stdlib files:

julia> @enter norm([1,2])
In norm(itr, p) at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.1\LinearAlgebra\src\generic.jl:448
1   1 ── %1  = (isempty)(itr)
2   └───       goto #4 if not %1
3   2 ── %3  = (eltype)(itr)

About to run: (isempty)([1, 2])
1|debug> 

Now we can:

julia> @enter norm([1,2])
In norm(itr, p) at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.1\LinearAlgebra\src\generic.jl:448
448       isempty(itr) && return float(norm(zero(eltype(itr))))
449       if p == 2
450           return norm2(itr)

The method printing is still wrong though.

@KristofferC KristofferC force-pushed the kc/stdlibz branch 2 times, most recently from feb6395 to d3ab668 Compare March 15, 2019 08:13
@KristofferC
Copy link
Member Author

I pushed a commit to also fixup the printing of the frame.

If this is too "hand-wavy" I'm happy just moving this to the debugger instead.

@pfitzseb
Copy link
Member

I still kinda feel like CodeTracking's whereis should handle this.

@KristofferC
Copy link
Member Author

Yeah, I'm inclined to agree. Would be simple to move there. Let's wait and see what Tim thinks.

@KristofferC
Copy link
Member Author

I guess we would still need it here for the frame printing and getfile but we could call the equivalent of maybe_find_stdlib_file from CodeTracking then.

@timholy
Copy link
Member

timholy commented Mar 15, 2019

#144 (comment).

But I'd be happy to have a PR in CodeTracking with this replacement operation! It should be performed here.

@KristofferC
Copy link
Member Author

@KristofferC KristofferC force-pushed the kc/stdlibz branch 2 times, most recently from 5b2ca68 to 8d1d0f0 Compare March 15, 2019 09:53
@KristofferC
Copy link
Member Author

KristofferC commented Mar 15, 2019

Updated the PR based on timholy/CodeTracking.jl#16. Note that the Manifest here for CodeTracking now refers to that PR branch (to run CI) on it but should not be merged as is.

@KristofferC KristofferC merged commit c0a3c75 into master Mar 16, 2019
@KristofferC KristofferC deleted the kc/stdlibz branch March 16, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants