Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for Flashback #13303

Closed
10 tasks done
JmPotato opened this issue Aug 18, 2022 · 2 comments
Closed
10 tasks done

Tracking Issue for Flashback #13303

JmPotato opened this issue Aug 18, 2022 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

JmPotato commented Aug 18, 2022 •
edited
Loading

Background

Since we store all MVCC versions of every key in TiKV since the last GC point, we have the ability to restore any key in any given range to any of the existing specified MVCC versions. Providing such an interface whose name is kv_flashback_to_version allows for data recovery capabilities like the Flashback feature.

Task
@JmPotato JmPotato added the type/enhancement The issue or PR belongs to an enhancement. label Aug 18, 2022
@JmPotato
Copy link
Member Author

/cc @HuSharp @Connor1996

@Defined2014 Defined2014 mentioned this issue Aug 18, 2022
Closed
20 tasks
This was referenced Aug 18, 2022
Merged
Closed
@HuSharp HuSharp mentioned this issue Aug 23, 2022
Closed
@bb7133 bb7133 mentioned this issue Aug 24, 2022
Closed
@JmPotato JmPotato mentioned this issue Aug 25, 2022
Merged
@HuSharp HuSharp mentioned this issue Aug 25, 2022
Merged
ti-chi-bot added a commit that referenced this issue Aug 30, 2022
@JmPotato @ti-chi-bot
storage: implement the FlashbackToVersion txn command (#13345)
40192af 
ref #13303

Implement the `FlashbackToVersion` txn command, which contains two phases: 
`command::FlashbackToVersionReadPhase` and `command::FlashbackToVersion`.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue Aug 30, 2022
Merged
ti-chi-bot added a commit that referenced this issue Sep 2, 2022
@HuSharp @ti-chi-bot
*: Block reads, writes and schedules before finishing flashback (#13348)
aaf124e 
ref #13303

Add Msg and peer's flashback state field

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit that referenced this issue Sep 2, 2022
@JmPotato
service: add the kv_flashback_to_version interface (#13378)
b8315ad 
ref #13303

Implement the `kv_flashback_to_version` interface.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
This was referenced Sep 2, 2022
Merged
Closed
@JmPotato JmPotato mentioned this issue Sep 14, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Sep 19, 2022
@JmPotato
storage: refactor flashback to use the MVCC overwriting (#13450)
6ed9d41 
ref #13303, close #13448

Since deleting the old MVCC keys directly will cause the GC Compaction Filter to mishandle the deletion entry,
this PR refactors the `FlashbackToVersionReadPhase` and `FlashbackToVersion` commands to use the MVCC
overwriting to achieve the flashback.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato added a commit to JmPotato/tikv that referenced this issue Sep 19, 2022
@JmPotato
storage: refactor flashback to use the MVCC overwriting (tikv#13450)
e02a623 
ref tikv#13303, close tikv#13448

Since deleting the old MVCC keys directly will cause the GC Compaction Filter to mishandle the deletion entry,
this PR refactors the `FlashbackToVersionReadPhase` and `FlashbackToVersion` commands to use the MVCC
overwriting to achieve the flashback.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
This was referenced Sep 20, 2022
Merged
Closed
ti-chi-bot added a commit that referenced this issue Sep 20, 2022
@JmPotato @ti-chi-bot
actions: use load_data to get the old value in flashback (#13492)
5277c5d 
ref #13303

Use `load_data` to get the old value in flashback to prevent unnecessary `seek_write`.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue Sep 22, 2022
Closed
3 tasks
@JmPotato JmPotato changed the title Add kv_flashback_to_version interface Tracking Issue for Flashback Sep 22, 2022
@JmPotato JmPotato mentioned this issue Sep 23, 2022
Merged
ti-chi-bot added a commit that referenced this issue Sep 26, 2022
@JmPotato @ti-chi-bot
commands: use ReaderWithStats in flashback_to_version command (#13525)
585763a 
ref #13303

Use `ReaderWithStats` in `flashback_to_version` command to collect the statistics info as much as possible.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@HuSharp HuSharp mentioned this issue Sep 28, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Oct 12, 2022
@HuSharp
*: Add a Raft admin command to put the region into a locking flashbac…
c286b8a 
…k state. (#13541)

ref #13303, ref #13519

Add a Raft admin command to put the region into a lock state to prevent any reading, writing, and scheduling and persist the state in the RegionLocalState.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
This was referenced Oct 17, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Oct 17, 2022
@JmPotato
raftstore: move check_flashback_state to after check_region_epoch (#1…
39961b1 
…3618)

ref #13303, ref pingcap/tidb#38475

Move `check_flashback_state` to after `check_region_epoch` to make sure the Region Cache on the client-side could be refreshed ASAP.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot added a commit that referenced this issue Oct 18, 2022
@JmPotato @ti-chi-bot
tests: refine the flashback raftstore test (#13615)
13f58a9 
ref #13303

Refine the flashback raftstore test.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@HuSharp HuSharp mentioned this issue Nov 8, 2022
Merged
@JmPotato
Copy link
Member Author

JmPotato commented Nov 9, 2022

Close since the basic Flashback ability has finished development.

@JmPotato JmPotato closed this as completed Nov 9, 2022
This was referenced Nov 14, 2022
Closed
Closed
Merged
ti-chi-bot added a commit that referenced this issue Nov 17, 2022
@JmPotato @ti-chi-bot
tests: refine the raftstore flashback tests (#13808)
cc7345a 
ref #13303

Refine the raftstore flashback tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@HuSharp HuSharp mentioned this issue Nov 22, 2022
Closed
ti-chi-bot added a commit that referenced this issue Nov 23, 2022
@HuSharp @ti-chi-bot
*: remove redundant code for prewrite and commit. (#13747)
71980d3 
ref #13303

remove redundant code for prewrite and commit.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@JmPotato JmPotato mentioned this issue May 31, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 1, 2023
@JmPotato
raftstore: block in-memory pessimistic locks during the flashback (#1…
9aa1d73 
…4859)

ref #13303, close pingcap/tidb#44292

During the Flashback process, we should prevent any read or write operations on the in-memory pessimistic lock table
and clear it like rolling back other locks to ensure that Flashback can proceed smoothly.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 1, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Jun 1, 2023
@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#14859
bb93810 
ref tikv#13303, close pingcap/tidb#44292

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 1, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Jun 1, 2023
@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#14859
aad9091 
ref tikv#13303, close pingcap/tidb#44292

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this issue Jun 5, 2023
@ti-chi-bot @JmPotato
raftstore: block in-memory pessimistic locks during the flashback (#1…
b0defbb 
…4859) (#14861)

ref #13303, ref #14859, close pingcap/tidb#44292

During the Flashback process, we should prevent any read or write operations on the in-memory pessimistic lock table
and clear it like rolling back other locks to ensure that Flashback can proceed smoothly.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Jun 16, 2023
@ti-chi-bot @JmPotato
raftstore: block in-memory pessimistic locks during the flashback (#1…
f650e63 
…4859) (#14862)

ref #13303, ref #14859, close pingcap/tidb#44292

During the Flashback process, we should prevent any read or write operations on the in-memory pessimistic lock table
and clear it like rolling back other locks to ensure that Flashback can proceed smoothly.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue Jun 21, 2023
Merged
@tonyxuqqi tonyxuqqi mentioned this issue Jun 21, 2023
Merged
16 tasks
tonyxuqqi pushed a commit to tonyxuqqi/tikv that referenced this issue Jun 22, 2023
@JmPotato @tonyxuqqi
raftstore: block in-memory pessimistic locks during the flashback (ti…
fd273d8 
…kv#14859)

ref tikv#13303, close pingcap/tidb#44292

During the Flashback process, we should prevent any read or write operations on the in-memory pessimistic lock table
and clear it like rolling back other locks to ensure that Flashback can proceed smoothly.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
ti-chi-bot bot pushed a commit that referenced this issue Jul 4, 2023
@JmPotato
tests: make test_flashback_with_in_memory_pessimistic_locks stable (#…
807297a 
…14986)

ref #13303, ref pingcap/tidb#44292

Make `test_flashback_with_in_memory_pessimistic_locks` stable.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
This was referenced Jul 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@JmPotato