Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvrpcpb, tikvpb: add kv_flashback_to_version interface #971

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

Ref tikv/tikv#13303.

@JmPotato JmPotato force-pushed the add_kv_flashback_to_version branch from 55c6bb7 to ecc85ea Compare August 18, 2022 07:23
@JmPotato
Copy link
Member Author

/cc @Connor1996 @HuSharp

@JmPotato JmPotato marked this pull request as draft August 18, 2022 08:30
@JmPotato JmPotato force-pushed the add_kv_flashback_to_version branch from 003fe57 to 0a03a67 Compare August 18, 2022 09:04
@JmPotato JmPotato force-pushed the add_kv_flashback_to_version branch 2 times, most recently from 62ec6d8 to 5e6f91a Compare August 18, 2022 10:22
@JmPotato JmPotato force-pushed the add_kv_flashback_to_version branch from 5e6f91a to 85c4738 Compare August 26, 2022 03:18
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the add_kv_flashback_to_version branch from 85c4738 to 08da9fe Compare August 30, 2022 04:06
@JmPotato JmPotato marked this pull request as ready for review August 30, 2022 04:07
@JmPotato
Copy link
Member Author

/merge

@Connor1996
Copy link
Member

@JmPotato merge it until tikv's PR is ready to be merged, otherwise others updating kvproto may encounter compile error.

@JmPotato
Copy link
Member Author

@JmPotato merge it until tikv's PR is ready to be merged, otherwise others updating kvproto may encounter compile error.

Ok!

@Connor1996
Copy link
Member

/merge

@rleungx
Copy link
Member

rleungx commented Sep 2, 2022

/merge

@rleungx rleungx merged commit f95ac33 into pingcap:master Sep 2, 2022
@JmPotato JmPotato deleted the add_kv_flashback_to_version branch September 2, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants