support codeception v4 #39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| language: php | ||
|
|
||
| php: | ||
| - 7.2 | ||
| - 7.3 | ||
| - 7.4 | ||
|
|
||
| before_script: | ||
| - composer update -n --prefer-dist --dev | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,11 +11,12 @@ | |||||
| } | ||||||
| ], | ||||||
| "require": { | ||||||
| "php": ">=7.2.0", | ||||||
| "codeception/codeception": "^4.0" | ||||||
|
There was a problem hiding this comment. since you never changed any code I presume that it is compatible with codeception 3.0, so ^3.0.0 | ^4.0.0 would be good There was a problem hiding this comment.
Suggested change
I think this decision is up to @tiger-seo cause it's mainly about the support commitment. It seems to currently work with both versions but this may increase maintenance costs or require another major release later. Added it as a suggestion so that tiger-seo can decide to apply or not before merging. There was a problem hiding this comment. well, if they break compatibility, then according to SEMVER they have to bump major, but since major is locked from version 3.x.x to 4.x.x then it should not be a problem |
||||||
| }, | ||||||
| "require-dev": { | ||||||
| "phpunit/phpunit": "6.*", | ||||||
| "codeception/module-phpbrowser": "^1.0" | ||||||
| }, | ||||||
| "autoload": { | ||||||
| "psr-0": { | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
1.5.xbranch does not exist yet. It needs to be created.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but somehow 1.5.0 tag exists since september of 2019