support codeception v4

[jelhan]

This is a breaking change. It drops support for

• codeception 3.x
• PHP < 7.2
• PHPUnit 5.x

Closes #38

[jelhan]

The 1.5.x branch does not exist yet. It needs to be created.

[mikk150]

but somehow 1.5.0 tag exists since september of 2019

[mikk150]

since you never changed any code I presume that it is compatible with codeception 3.0, so ^3.0.0 | ^4.0.0 would be good

[jelhan]

Suggested change

	"codeception/codeception": "^4.0"
	"codeception/codeception": "^3.0 || ^4.0"

I think this decision is up to @tiger-seo cause it's mainly about the support commitment. It seems to currently work with both versions but this may increase maintenance costs or require another major release later. Added it as a suggestion so that tiger-seo can decide to apply or not before merging.

[mikk150]

well, if they break compatibility, then according to SEMVER they have to bump major, but since major is locked from version 3.x.x to 4.x.x then it should not be a problem

[jelhan]

@tiger-seo Any chance to get this one merged?

[tiger-seo]

@jelhan sorry for not responding; why do u suggest to drop codeception 3.0 and bump major version of this extension ?

[jelhan]

@jelhan sorry for not responding; why do u suggest to drop codeception 3.0 and bump major version of this extension ?

Mostly two reasons if I recall correctly:

1. All supported combinations should be covered by tests. The current setup does not support running the tests against multiple versions of codeception. And I was too lazy to set that up myself.
2. Supporting multiple versions at the same time increases maintenance costs. I think in that case it's better to focus the limited resources.

But at the end of the day that decision is up to you.

[gimler]

@tiger-seo any update?

+1 for drop support for legacy codeception/php version

I think when someone use a old codeception version he can use a specific branch like described in the readme

[airdrummingfool]

It would be great to see this PR (or #43) merged, but until that happens I am using the code from this PR via a workaround in composer.json:

change the require line to:

"codeception/phpbuiltinserver": "dev-codeception-4",

add:

    "repositories": [
      {
        "type": "vcs",
        "url": "https://github.com/jelhan/PhpBuiltinServer"
      }
    ],

This overrides the PHPBuiltinServer from Packagist with @jelhan's fork, and pulls the codeception-4 branch.

Ref:

• https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

[gimler]

@tiger-seo any update here for support codeception v4?

[Mte90]

Ping for this PR!

[Mte90]

I see with php 8.1 some issues:

PHP Warning:  proc_open(): Unable to copy file descriptor 7 (for pipe) into file descriptor 1: Bad file descriptor
PHP Warning:  proc_open(): Unable to copy file descriptor 8 (for pipe) into file descriptor 1: Bad file descriptor

[xepozz]

any updates here?

[mikk150]

any updates here?

master branch already supports codeception 4

[jelhan]

Already implemented with #43. Closing this one to avoid confusion.