feat: system diagnostic monitor message #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
7 tasks
5 tasks
mitsudome-r
reviewed
Sep 5, 2023
Comment on lines
3
to
9
| byte stop | ||
| byte autonomous | ||
| byte local | ||
| byte remote | ||
| byte emergency_stop | ||
| byte comfortable_stop | ||
| byte pull_over |
There was a problem hiding this comment.
Can't these be boolean values?
There was a problem hiding this comment.
Changed 62c3ddd
Comment on lines
1
to
2
| uint32 index | ||
| bool used |
There was a problem hiding this comment.
We might want to have a README for this message to explain what these fields mean.
There was a problem hiding this comment.
Add comment ddcc615
There was a problem hiding this comment.
If this is specifically used to express each operation mode, then it might be better to change the name to something like "OperationModeDiagnositics", "OperationModeAvailability", etc.
There was a problem hiding this comment.
Renamed 62c3ddd
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
yukkysaito
approved these changes
Sep 15, 2023
|
Just as a record, LGTM |
isamu-takagi
added a commit
that referenced
this pull request
Nov 30, 2023
* feat: add diagnostic graph Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update diagnostic graph Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add links Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: split status and struct Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add summary Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add link Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add stamp Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add stamp Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * rename message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Links
autowarefoundation/autoware.universe#3829 (comment)
Description
Add diagnostic graph message.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks