Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_msgs): improve diagnostic graph efficiency #113

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 15, 2024

Related Links

#96, autowarefoundation/autoware.universe#3829

Description

Messages created in #96 were also sending static data every time. This PR improves communication efficiency by dividing the message into static and dynamic parts. See README for details.

Remarks

Remove the previous DiagnosticGraph message after reflecting the changes in the diagnostics_graph_aggregator package.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi force-pushed the feat/improve-diagnostic-graph-efficiency branch from 2174d35 to e774dd6 Compare February 15, 2024 06:48
@isamu-takagi isamu-takagi self-assigned this Feb 20, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review February 20, 2024 10:29
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@yukkysaito yukkysaito merged commit dd006f2 into tier4:tier4/universe Mar 11, 2024
10 checks passed
@isamu-takagi isamu-takagi deleted the feat/improve-diagnostic-graph-efficiency branch March 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants