Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): fix pre-commit error when prettier has no files to process #258

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 4, 2025

PR Type

  • Improvement

Related Links

Description

Add the --no-error-on-unmatched-pattern option to prettier so an empty file list will not cause pre-commit to fail.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

… process

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex self-assigned this Feb 4, 2025
@mojomex mojomex merged commit 8edab25 into main Feb 4, 2025
7 of 8 checks passed
@mojomex mojomex deleted the chore/prettier-allow-empty-file-list branch February 4, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant