-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hesai_hw_interface): use new UDP socket implementation #235
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 27.24% 1.94% -25.31%
==========================================
Files 104 91 -13
Lines 9447 8171 -1276
Branches 2326 1052 -1274
==========================================
- Hits 2574 159 -2415
- Misses 6435 7958 +1523
+ Partials 438 54 -384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
91b7e0e
to
4619c06
Compare
edccdbb
to
ab9a02d
Compare
commit ab9a02d Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Dec 23 08:58:24 2024 +0000 ci(pre-commit): autofix commit f11d2fa Author: Max SCHMELLER <max.schmeller@tier4.jp> Date: Mon Dec 23 17:54:52 2024 +0900 chore(hesai): disallow 255.255.255.255 in config Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> commit 25a2d98 Author: Max SCHMELLER <max.schmeller@tier4.jp> Date: Tue Nov 19 17:42:31 2024 +0900 fix(hesai): gracefully stop receiver thread on shutdown to prevent SEGFAULT Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> commit ceb2965 Author: Max SCHMELLER <max.schmeller@tier4.jp> Date: Tue Nov 19 15:14:49 2024 +0900 feat(hesai): switch to new UDP socket implementation Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left one comment, but looking at the code std::copy
was used previously so the header is needed.
I checked test coverage - everything in there is covered by the UDP socket tests, but the usage is not well covered by the Hesai HW interface tests. As this is not an issue with this PR individually, all good to merge 👍
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…GFAULT Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
ab9a02d
to
9afaf9e
Compare
PR Type
Related Links
Description
Use the new UDP socket introduced in #231 as a drop-in, ASIO-free, transport-driver-free replacement for the old UdpDriver in HesaiHwInterface.
Tested on the 2nd gen bus reference vehicle.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks