Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hesai_hw_interface): use new UDP socket implementation #235

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 25, 2024

PR Type

  • Improvement

Related Links

Description

Use the new UDP socket introduced in #231 as a drop-in, ASIO-free, transport-driver-free replacement for the old UdpDriver in HesaiHwInterface.

Tested on the 2nd gen bus reference vehicle.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 1.94%. Comparing base (86fe233) to head (9afaf9e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% 17 Missing ⚠️
...ros/include/nebula_ros/hesai/hesai_ros_wrapper.hpp 0.00% 5 Missing ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (86fe233) and HEAD (9afaf9e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (86fe233) HEAD (9afaf9e)
total 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #235       +/-   ##
==========================================
- Coverage   27.24%   1.94%   -25.31%     
==========================================
  Files         104      91       -13     
  Lines        9447    8171     -1276     
  Branches     2326    1052     -1274     
==========================================
- Hits         2574     159     -2415     
- Misses       6435    7958     +1523     
+ Partials      438      54      -384     
Flag Coverage Δ
differential 1.94% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex changed the title Feat/hesai new udp socket feat(hesai_hw_interface): use new UDP socket implementation Nov 25, 2024
mojomex added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
mojomex added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch from 91b7e0e to 4619c06 Compare December 2, 2024 07:34
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch 2 times, most recently from edccdbb to ab9a02d Compare December 24, 2024 07:03
@mojomex mojomex requested a review from drwnz December 27, 2024 07:47
mojomex added a commit that referenced this pull request Feb 3, 2025
commit ab9a02d
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Dec 23 08:58:24 2024 +0000

    ci(pre-commit): autofix

commit f11d2fa
Author: Max SCHMELLER <max.schmeller@tier4.jp>
Date:   Mon Dec 23 17:54:52 2024 +0900

    chore(hesai): disallow 255.255.255.255 in config

    Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

commit 25a2d98
Author: Max SCHMELLER <max.schmeller@tier4.jp>
Date:   Tue Nov 19 17:42:31 2024 +0900

    fix(hesai): gracefully stop receiver thread on shutdown to prevent SEGFAULT

    Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

commit ceb2965
Author: Max SCHMELLER <max.schmeller@tier4.jp>
Date:   Tue Nov 19 15:14:49 2024 +0900

    feat(hesai): switch to new UDP socket implementation

    Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left one comment, but looking at the code std::copy was used previously so the header is needed.

I checked test coverage - everything in there is covered by the UDP socket tests, but the usage is not well covered by the Hesai HW interface tests. As this is not an issue with this PR individually, all good to merge 👍

nebula_ros/src/hesai/hesai_ros_wrapper.cpp Outdated Show resolved Hide resolved
mojomex and others added 4 commits February 4, 2025 10:49
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…GFAULT

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch from ab9a02d to 9afaf9e Compare February 4, 2025 02:00
@mojomex mojomex merged commit 6eb72b5 into main Feb 4, 2025
10 of 12 checks passed
@mojomex mojomex deleted the feat/hesai-new-udp-socket branch February 4, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants