This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for other review.
takayuki5168
previously approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isamu-takagi , should I wait for other reviewer or I can merge it now? |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
takayuki5168
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
0x126
pushed a commit
that referenced
this pull request
Sep 20, 2022
* add rviz helper for ad api Signed-off-by: khtan <tkh.my.p@gmail.com> * sync for init pose Signed-off-by: khtan <tkh.my.p@gmail.com> * add missing sync Signed-off-by: khtan <tkh.my.p@gmail.com> * add rviz adaptor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix launch_dummy_localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: khtan <tkh.my.p@gmail.com> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
autowarefoundation/autoware_launch#70
autowarefoundation/autoware.universe#1494
autowarefoundation/autoware_launch#72
autowarefoundation/autoware.universe#1500
autowarefoundation/autoware.universe#1431
Description
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks