Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: sync launch for init pose #486

Merged
merged 8 commits into from
Sep 16, 2022

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Sep 16, 2022

PR Type

  • sync

Related Links

autowarefoundation/autoware_launch#70
autowarefoundation/autoware.universe#1494
autowarefoundation/autoware_launch#72
autowarefoundation/autoware.universe#1500
autowarefoundation/autoware.universe#1431

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

tkhmy and others added 6 commits September 16, 2022 13:21
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@tkhmy tkhmy marked this pull request as ready for review September 16, 2022 05:56
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for other review.

takayuki5168
takayuki5168 previously approved these changes Sep 16, 2022
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkhmy
Copy link
Contributor Author

tkhmy commented Sep 16, 2022

@isamu-takagi , should I wait for other reviewer or I can merge it now?

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 31f48d9 into awf-latest Sep 16, 2022
@isamu-takagi isamu-takagi deleted the feature/sync_autoware_launch branch September 16, 2022 06:14
0x126 pushed a commit that referenced this pull request Sep 20, 2022
* add rviz helper for ad api

Signed-off-by: khtan <tkh.my.p@gmail.com>

* sync for init pose

Signed-off-by: khtan <tkh.my.p@gmail.com>

* add missing sync

Signed-off-by: khtan <tkh.my.p@gmail.com>

* add rviz adaptor

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix launch_dummy_localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: khtan <tkh.my.p@gmail.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants