-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pose_initializer)!: support ad api #1500
feat(pose_initializer)!: support ad api #1500
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
What reason did you use upper camel case for function? I know google coding style recommend upper camel case for function. But many autoware code use lower camel case or snake case. So it may make to confuse. |
@yukkysaito I think that it will be unified with the |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
6b30c42
to
3901ab4
Compare
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportBase: 10.43% // Head: 10.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
- Coverage 10.43% 10.12% -0.31%
==========================================
Files 1226 1212 -14
Lines 87947 86805 -1142
Branches 20457 20112 -345
==========================================
- Hits 9176 8790 -386
+ Misses 69269 68797 -472
+ Partials 9502 9218 -284
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
localization/pose_initializer/src/map_height_fitter/map_height_fitter_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi Could you please add a readme for |
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Show resolved
Hide resolved
…api/pose-initializer
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
60d5249
to
6c825d7
Compare
Please add descriptions of |
It seemed to be included in #1431. |
localization/pose_initializer/launch/pose_initializer.launch.xml
Outdated
Show resolved
Hide resolved
I performed the test described in |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi Could you fix the CI/CD error |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please merge at the same time with #1431.
* feat(pose_initializer): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define localization interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: main function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add readme of localization message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify stop check time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat(pose_initializer): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define localization interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: main function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add readme of localization message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify stop check time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat(pose_initializer): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define localization interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: main function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add readme of localization message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify stop check time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat(pose_initializer): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: auto format Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define localization interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: copyright Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: main function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add readme of localization message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify stop check time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…0-1/lc_condition fix(lane_change): modify lane change requested condition (autowarefoundation#8510)
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Introduce AD API for localization. This PR is the pose_initializer, map_height_fitter, and GNSS module part of the diagram.
Here are the changes and related packages:
Main change. The basic idea is to replace initialpose with API. Initialpose is only used for conversion to API by adaptor node. This ensures that all pose initialization is managed by pose_initializer. Finally, pose_initializer publishes the initialized pose to the other nodes as
initialpose3d
(this pose is aligned by NDT scan matcher) .Add the message and the internal localization interface definitions.
Use initialpose3d instead of initialpose/initialpose2d.
Remove unused field
seq
and unused messagePoseInitializationRequest
.Replace from old initialize service.
Related links
autowarefoundation/autoware_launch#72
tier4/tier4_autoware_msgs#44
Tests performed
For planning simulation, check if pose initialization can be done at any time.
For logging simulation, check if pose initialization can be done when vehicle stops.
ros2 service call /localization/initialize autoware_ad_api_msgs/srv/InitializeLocalization "pose: []"
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.