Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: port missing enum in ControlMode from tier4 ControlMode msg #33

Merged
merged 1 commit into from
Oct 20, 2022
Merged

refactor!: port missing enum in ControlMode from tier4 ControlMode msg #33

merged 1 commit into from
Oct 20, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 8, 2022 •
edited
Loading

  • Add enum in ControlModeReport to support options in Tier4's ControlMode
  • Add ControlModeCommand srv.

See autowarefoundation/autoware.universe#1509 for the background.

For T4 issue tracking: https://tier4.atlassian.net/browse/T4PB-18987

@TakaHoribe
Port missing enum in ControlMode from tier4 ControlMode msg
df74c00 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from mitsudome-r August 8, 2022 01:55
@TakaHoribe TakaHoribe changed the title feat: port missing enum in ControlMode from tier4 ControlMode msg feat!: port missing enum in ControlMode from tier4 ControlMode msg Aug 8, 2022
@TakaHoribe TakaHoribe changed the title feat!: port missing enum in ControlMode from tier4 ControlMode msg refactor!: port missing enum in ControlMode from tier4 ControlMode msg Aug 8, 2022
@TakaHoribe TakaHoribe mentioned this pull request Aug 8, 2022
Closed
3 tasks
mitsudome-r
mitsudome-r approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit bd16258 into tier4/main Oct 20, 2022
@TakaHoribe TakaHoribe deleted the refactor/remove-tier4-control-mode-msg branch October 20, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakaHoribe @mitsudome-r