Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated ControlMode msgs #1509

Closed
3 tasks done
TakaHoribe opened this issue Aug 3, 2022 · 4 comments
Closed
3 tasks done

Remove duplicated ControlMode msgs #1509

TakaHoribe opened this issue Aug 3, 2022 · 4 comments
Assignees
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@TakaHoribe
Copy link
Contributor

TakaHoribe commented Aug 3, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Now there are duplicated control mode messages.

Engage Related:

The goal is to combine them and remove duplicated messages.

Purpose

To improve the maintainability.

Possible approaches

Remove ControlMode in tier4 msgs. The missing information will be added in the autoware_auto_vehicle_msgs.

Definition of done

No duplicated messages of ControlMode.

@TakaHoribe TakaHoribe added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 3, 2022
@TakaHoribe TakaHoribe self-assigned this Aug 3, 2022
@TakaHoribe
Copy link
Contributor Author

TakaHoribe commented Aug 3, 2022

The ControlMode in tier4 msgs will be removed.

However, the service to tell the ControlMode is needed for the current implementation, and thus add ControlModeCommand.srvto autoware_auto_vehicle_msg. Since there will be twoControlMode` messages in topic and service, it is desirable to remove one of them after discussion.

@stale
Copy link

stale bot commented Oct 7, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 7, 2022
@TakaHoribe
Copy link
Contributor Author

Finally, all PRs are merged. Close this issue.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 20, 2022
saka1-s added a commit to saka1-s/autoware.universe that referenced this issue Nov 1, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Tiankui Xian <1041084556@qq.com>
Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants