Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): clear costmap on adjacent lanes #404

Merged
merged 4 commits into from
May 1, 2023
Merged

Conversation

soblin
Copy link

@soblin soblin commented May 1, 2023

Description

自車レーン上で死角認識をしないように修正

Same as autowarefoundation#3553

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

soblin added 4 commits May 1, 2023 13:22
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
* always set RTC distance to default stop line/occlusion stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* initialize RTC status as non occluded at intersection module construction

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* removed debug print

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* keep waiting at 1st stop lineif externally occlusion is requested

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…arefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…on#3553)

clear costmap on adjacent lanes

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3117b3a) 3.45% compared to head (23a4c88) 3.44%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           beta/v0.8.0    #404      +/-   ##
==============================================
- Coverage         3.45%   3.44%   -0.01%     
==============================================
  Files               99      99              
  Lines             7468    7485      +17     
  Branches          4084    4098      +14     
==============================================
  Hits               258     258              
- Misses            7016    7033      +17     
  Partials           194     194              
Flag Coverage Δ
differential 3.44% <0.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <ø> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shmpwk shmpwk merged commit b90b733 into beta/v0.8.0 May 1, 2023
@shmpwk shmpwk deleted the hotfix/3553 branch May 1, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants