-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner::intersection): strictly wait at 1st stop line when occlusion is detected #3528
fix(behavior_velocity_planner::intersection): strictly wait at 1st stop line when occlusion is detected #3528
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
8ff48b4
to
2517e27
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
==========================================
- Coverage 14.05% 14.05% -0.01%
==========================================
Files 1397 1397
Lines 98030 98037 +7
Branches 29104 29115 +11
==========================================
Hits 13779 13779
- Misses 69588 69594 +6
- Partials 14663 14664 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Tighten the condition for first phase stop timeout by starting waiting when vehicle get stopped.
Related links
https://tier4.atlassian.net/browse/RT1-2240
Tests performed
Before this PR
The vehicle does not wait for 1sec exaclty.
before_pr_3528-2023-04-25_17.28.32.mp4
After this PR
The vehicle waits for 1sec.
after_pr_3528-2023-04-25_17.21.52.mp4
Notes for reviewers
Not applicable
Interface changes
Not applicable
Effects on system behavior
The vehicle will wait for exactly specified time
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.