Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner::intersection): strictly wait at 1st stop line when occlusion is detected #3528

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 25, 2023

Description

Tighten the condition for first phase stop timeout by starting waiting when vehicle get stopped.

Related links

https://tier4.atlassian.net/browse/RT1-2240

Tests performed

Before this PR

The vehicle does not wait for 1sec exaclty.

before_pr_3528-2023-04-25_17.28.32.mp4

After this PR

The vehicle waits for 1sec.

after_pr_3528-2023-04-25_17.21.52.mp4

Notes for reviewers

Not applicable

Interface changes

Not applicable

Effects on system behavior

The vehicle will wait for exactly specified time

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 25, 2023
@soblin soblin changed the title Fix/intersection occlusion stop time fix(behavior_velocity_planner::intersection): strictly wait at 1st stop line when occlusion is detected Apr 25, 2023
soblin added 4 commits April 25, 2023 17:32
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/intersection-occlusion-stop-time branch from 8ff48b4 to 2517e27 Compare April 25, 2023 08:32
@soblin soblin marked this pull request as ready for review April 25, 2023 08:38
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (001a865) 14.05% compared to head (2517e27) 14.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
- Coverage   14.05%   14.05%   -0.01%     
==========================================
  Files        1397     1397              
  Lines       98030    98037       +7     
  Branches    29104    29115      +11     
==========================================
  Hits        13779    13779              
- Misses      69588    69594       +6     
- Partials    14663    14664       +1     
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.06% <ø> (+<0.01%) ⬆️ Carriedforward from 001a865

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 7a2cefa into autowarefoundation:main Apr 25, 2023
@soblin soblin deleted the fix/intersection-occlusion-stop-time branch April 26, 2023 10:35
soblin added a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants