Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change timeout in approval handler #40

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Apr 22, 2022

Description

In some cases, even if the lane change is approved, it will time out in the approval_handler and the lane change will not be executed.
It is a temporary fix for that

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tkimura4 tkimura4 force-pushed the feature/tmp/change_timeout_approval_handler branch from 932655f to e087296 Compare April 22, 2022 02:30
@tkimura4 tkimura4 changed the title Feature/tmp/change timeout approval handler feat: change timeout in approval handler Apr 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.2.1@700a826). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             beta/v0.2.1     #40   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?      34           
  Lines                  ?    4873           
  Branches               ?       0           
=============================================
  Hits                   ?       0           
  Misses                 ?    4873           
  Partials               ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700a826...bffa1cf. Read the comment docs.

@tkimura4 tkimura4 requested a review from taikitanaka3 April 26, 2022 06:18
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 force-pushed the feature/tmp/change_timeout_approval_handler branch from 7ce0c90 to bffa1cf Compare April 26, 2022 06:20
Copy link

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 1ce0ab8 into tier4:beta/v0.2.1 May 10, 2022
@tkimura4 tkimura4 deleted the feature/tmp/change_timeout_approval_handler branch May 10, 2022 02:17
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants