Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planning_test_utils): add subscriber existance checker and topic name validation #392

Closed

Conversation

kyoichi-sugahara
Copy link

@kyoichi-sugahara kyoichi-sugahara commented Apr 27, 2023

Description

merge PR from
autowarefoundation#3401
autowarefoundation#3404
autowarefoundation#3462
autowarefoundation#3661
autowarefoundation#3486

Tests performed

Not applicable

Effects on system behavior

no effect on system behavior. Test is implemented.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

tkimura4 and others added 4 commits April 27, 2023 10:27
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
feat: use new behavior_path_planner architecture
* add readme

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix table

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* describe in japanese

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add usage

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* update description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* tlanslate into English

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add implemtented tests

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add Important notes

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete images

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Revert "delete images"

This reverts commit 0524835.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete images

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add test name for behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…opic name validation (autowarefoundation#3462)

* add subscriber existance checker and topic name validation

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change function structure

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* refactor

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* refactor

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete ASSERT_NO_THROW

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify test files in motion_velocity_smoother and planning_validator

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify test files in obstacle_velocity_limiter, obstacle_stop_planner and obstacle_velocity_limiter

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify test files in scenario_selector

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify test files in freespace_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify test files in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Remove ament_cmake_gtest dependency from the planning_test_utils package

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation planning labels Apr 27, 2023
@kyoichi-sugahara kyoichi-sugahara changed the title Refactor/update planning test utils refactor(planning_test_utils): add subscriber existance checker and topic name validation Apr 27, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/update-planning-test-utils branch May 31, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants