-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(planning_test_utils): add subscriber existance checker and topic name validation #3462
refactor(planning_test_utils): add subscriber existance checker and topic name validation #3462
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… and obstacle_velocity_limiter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3462 +/- ##
==========================================
- Coverage 14.05% 13.95% -0.10%
==========================================
Files 1397 1397
Lines 98030 100151 +2121
Branches 29104 30648 +1544
==========================================
+ Hits 13779 13980 +201
- Misses 69588 71278 +1690
- Partials 14663 14893 +230
*This pull request uses carry forward flags. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obstacle stop planner
@purewater0901 @takayuki5168 @maxime-clem
|
…opic name validation (autowarefoundation#3462) * add subscriber existance checker and topic name validation Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change function structure Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete ASSERT_NO_THROW Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in motion_velocity_smoother and planning_validator Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in obstacle_velocity_limiter, obstacle_stop_planner and obstacle_velocity_limiter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in scenario_selector Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in freespace_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Remove ament_cmake_gtest dependency from the planning_test_utils package Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix typo Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…opic name validation (autowarefoundation#3462) * add subscriber existance checker and topic name validation Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change function structure Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * refactor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete ASSERT_NO_THROW Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in motion_velocity_smoother and planning_validator Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in obstacle_velocity_limiter, obstacle_stop_planner and obstacle_velocity_limiter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in scenario_selector Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in freespace_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify test files in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Remove ament_cmake_gtest dependency from the planning_test_utils package Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix typo Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
ament_cmake_gtest
dependency from theplanning_test_utils
packageTests performed
run the test with following command and all success
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.