Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update roi_cluster_fusion #318

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Mar 15, 2023

Description

See autowarefoundation#2659

Related links

( autowarefoundation#2701): cherry-pick to avoid conflicts
autowarefoundation#2844

Tests performed

tested by logging_simulator

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

badai-nguyen and others added 2 commits March 15, 2023 14:41
…on#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…towarefoundation#2844)

* feat(image_projection_based_fusion): add thrust distance to fusion

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

* feat(image_projection_based_fusion): fix typo

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.7.0-odaiba1@13083d2). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                  Coverage Diff                  @@
##             beta/v0.7.0-odaiba1    #318   +/-   ##
=====================================================
  Coverage                       ?   0.00%           
=====================================================
  Files                          ?      11           
  Lines                          ?     694           
  Branches                       ?       0           
=====================================================
  Hits                           ?       0           
  Misses                         ?     694           
  Partials                       ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 4dfb3fa into beta/v0.7.0-odaiba1 Mar 15, 2023
@tkimura4 tkimura4 deleted the feat/image-projection-based-fusion branch March 15, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants