Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_cluster_fusion): add unknown-object removal #2701

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 20, 2023

Signed-off-by: badai-nguyen dai.nguyen@tier4.jp

Description

This PR removes the Unknown objects remained after camera rois and clusters fusion. The purpose is to reduce detected obstacles coming from pointclouds such as exhaust gas or dense raindrops.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 12.16% // Head: 12.12% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (981a14a) compared to base (87641bf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   12.16%   12.12%   -0.04%     
==========================================
  Files        1177     1182       +5     
  Lines       83520    83779     +259     
  Branches    23649    23649              
==========================================
  Hits        10158    10158              
- Misses      62590    62849     +259     
  Partials    10772    10772              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.16% <0.00%> (ø) Carriedforward from 87641bf

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...usion/src/pointpainting_fusion/voxel_generator.cpp 0.00% <0.00%> (ø)
...sion/src/pointpainting_fusion/preprocess_kernel.cu 0.00% <0.00%> (ø)
...ion/src/pointpainting_fusion/pointpainting_trt.cpp 0.00% <0.00%> (ø)
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% <0.00%> (ø)
...ed_fusion/pointpainting_fusion/voxel_generator.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@badai-nguyen badai-nguyen requested a review from miursh January 20, 2023 04:23
@badai-nguyen badai-nguyen marked this pull request as ready for review January 20, 2023 04:24
@badai-nguyen badai-nguyen requested review from yukkysaito, yukke42 and a team as code owners January 20, 2023 04:24
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to remove UNKNOWN objects only for clustering and roi fusion.
If the result with CenterPoint does not match, will it still be output?

@badai-nguyen
Copy link
Contributor Author

@yukkysaito

I want to remove UNKNOWN objects only for clustering and roi fusion. If the result with CenterPoint does not match, will it still be output?

yes, this only remove UNKNOWN right after fusing clustering and roi, so not-matched results with CenterPoint will be remained.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit f16ec2e into autowarefoundation:main Jan 20, 2023
@badai-nguyen badai-nguyen deleted the fix/add_unknown_object_removal_option branch January 27, 2023 08:33
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…on#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…on#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
badai-nguyen added a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
…on#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
* refactor scripts

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* refactor workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add role key

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* specify fully qualified role names

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* update comment

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* update console output

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 15, 2023
…on#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Mar 15, 2023
* fix(roi_cluster_fusion): add unknown-object removal (autowarefoundation#2701)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* feat(image_projection_based_fusion): add trust distance to fusion (autowarefoundation#2844)

* feat(image_projection_based_fusion): add thrust distance to fusion

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

* feat(image_projection_based_fusion): fix typo

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants