-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(roi_cluster_fusion): add unknown-object removal #2701
fix(roi_cluster_fusion): add unknown-object removal #2701
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov ReportBase: 12.16% // Head: 12.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
- Coverage 12.16% 12.12% -0.04%
==========================================
Files 1177 1182 +5
Lines 83520 83779 +259
Branches 23649 23649
==========================================
Hits 10158 10158
- Misses 62590 62849 +259
Partials 10772 10772
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to remove UNKNOWN objects only for clustering and roi fusion.
If the result with CenterPoint does not match, will it still be output?
yes, this only remove UNKNOWN right after fusing clustering and roi, so not-matched results with CenterPoint will be remained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…on#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…on#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* refactor scripts Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * refactor workflows Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add role key Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * specify fully qualified role names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * update comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * update console output Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
…on#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* fix(roi_cluster_fusion): add unknown-object removal (autowarefoundation#2701) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat(image_projection_based_fusion): add trust distance to fusion (autowarefoundation#2844) * feat(image_projection_based_fusion): add thrust distance to fusion Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * feat(image_projection_based_fusion): fix typo Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: badai-nguyen dai.nguyen@tier4.jp
Description
This PR removes the Unknown objects remained after camera rois and clusters fusion. The purpose is to reduce detected obstacles coming from pointclouds such as exhaust gas or dense raindrops.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.