Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler): mrm recoverable option #1818

Open
wants to merge 7 commits into
base: beta/v0.41
Choose a base branch
from

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Feb 14, 2025

Description

PR for launcher: tier4/autoware_launch#760

Tip

These options are disabled as default parameters in the launcher PR, and there are no behavior changes as default.

This PR introduces the following features:

  • autoware_mrm_handler
    • Added an option to make MRM behavior non-recoverable when it occurs.
    • This option is enabled when is_mrm_recoverable is set to false.
  • recovery node
    • Even if is_mrm_recoverable is set to false, the MRM behavior will be recovered unless it is associated with a fatal_error in the diagnostic_graph tree.
    • This node will not be launched as default.

Related links

TIER IV INTERNAL LINK

TIER IV INTERNAL JIRA

How was this PR tested?

I confirmed that the MRM works when the associated diagnostics occuered.
I used default config for this test.

mrm_recoverable_test.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

TomohitoAndo and others added 4 commits February 14, 2025 12:01
* feat(mrm_handler): mrm recoverable option (#1316)

* implement is_mrm_recoverable option of mrm_handler

* add pull over after stopped option

* update json schema of mrm_handler

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: implement service for clear MRM behavior (#1511)

* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: implement MRM automatic recovery feature

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title feat(mrm_handler): mrm recoverable option (#1316) (#1654) feat(mrm_handler): mrm recoverable option Feb 14, 2025
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review February 14, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant