feat(x1): restore blind spot setting of livox view range from 1.0 to 1.5 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
h-ohta
approved these changes
Apr 14, 2023
yn-mrse
added a commit
that referenced
this pull request
Apr 14, 2023
…1.5 (#122) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding the short-distance detection function applied in #107 , it was found that a large amount of noise was generated in the actual vehicle.
This problem causes the vehicle to repeatedly stop unintentionally, so we restore the sensor field of view range setting that was reduced in #107 .
Related links
#107
Tests performed
No special testing is expected as this is a numerical change only and is the original numerical value used.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.