-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x1): update livox min range to 1.0m #107
Merged
yn-mrse
merged 6 commits into
tier4/universe
from
feat/x1/update_livox_min_range_to_1.0m
Feb 21, 2023
Merged
feat(x1): update livox min range to 1.0m #107
yn-mrse
merged 6 commits into
tier4/universe
from
feat/x1/update_livox_min_range_to_1.0m
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
…iations Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
YoheiMishina
approved these changes
Feb 21, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-beta/v2022.05.1 beta/v2022.05.1
# Navigate to the new working tree
cd .worktrees/backport-beta/v2022.05.1
# Create a new branch
git switch --create backport-107-to-beta/v2022.05.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d5deb74b39ba3a4e595e13e6fc8a6d0cc95718e4
# Push it to GitHub
git push --set-upstream origin backport-107-to-beta/v2022.05.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-beta/v2022.05.1 Then, create a pull request where the |
tier4-autoware-public-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
* feat(x1): copy new_livox_horizon from common_sensor_launch Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1): remove dependency on common_sensor_launch Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1/livox): parameterize min_range to accommodate multiple hw variations Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1/livox): update livox min range to 1.0m Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> --------- Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> (cherry picked from commit d5deb74)
yn-mrse
added a commit
that referenced
this pull request
Feb 21, 2023
feat(x1): update livox min range to 1.0m (#107) * feat(x1): copy new_livox_horizon from common_sensor_launch Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1): remove dependency on common_sensor_launch Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1/livox): parameterize min_range to accommodate multiple hw variations Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat(x1/livox): update livox min range to 1.0m Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> --------- Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> (cherry picked from commit d5deb74) Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
!!! This PR assumes that the #104 has been merged. !!!
This PR applies to the close-range version of livox_horizon.
With this PR, the vehicle will be able to see up to a close distance of 1.0[m], which is the limit of the hardware specs of the close range version of livox.
Related links
T4PB-25423 (TIERIV, INC. INTERNAL LINK)
#104
Tests performed
Assumptions:
Originally, the min_range crop function was used to remove near-field noise from lidar sensors.
In the case of the livox sensor, there is a feature that sensor noise is detected in front of the actual object.
Especially when driving on a narrow road, sensor noise from obstacles on the left and right of the lane may enter the lane.
In this case, the vehicle may erroneously detect as if there is an obstacle ahead.
Validation:
A running test was conducted on a narrow road with a width of 1.75 [m], which is the worst condition assumed under x1 usage conditions.
We have confirmed that it can pass through obstacles without false detection.
Verification:
After launch, confirm that the settings have been reflected with the following command.
ros2 param get /sensing/lidar/front_center/crop_box_filter_min_range max_x
As expected, the result is shown below.
Double value is: 1.0
I did the same test on the left and right and got the same results.
Notes for reviewers
This PR assumes that the #104 has been merged.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.