Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x1): update livox min range to 1.0m #107

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

yn-mrse
Copy link
Contributor

@yn-mrse yn-mrse commented Feb 19, 2023

Description

!!! This PR assumes that the #104 has been merged. !!!

This PR applies to the close-range version of livox_horizon.
With this PR, the vehicle will be able to see up to a close distance of 1.0[m], which is the limit of the hardware specs of the close range version of livox.

Related links

T4PB-25423 (TIERIV, INC. INTERNAL LINK)
#104

Tests performed

Assumptions:
Originally, the min_range crop function was used to remove near-field noise from lidar sensors.
In the case of the livox sensor, there is a feature that sensor noise is detected in front of the actual object.
Especially when driving on a narrow road, sensor noise from obstacles on the left and right of the lane may enter the lane.
In this case, the vehicle may erroneously detect as if there is an obstacle ahead.

Validation:
A running test was conducted on a narrow road with a width of 1.75 [m], which is the worst condition assumed under x1 usage conditions.
We have confirmed that it can pass through obstacles without false detection.

Verification:
After launch, confirm that the settings have been reflected with the following command.
ros2 param get /sensing/lidar/front_center/crop_box_filter_min_range max_x
As expected, the result is shown below.
Double value is: 1.0
I did the same test on the left and right and got the same results.

Notes for reviewers

This PR assumes that the #104 has been merged.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
…iations

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
@yn-mrse yn-mrse changed the title feat(x1) update livox min range to 1.0m feat(x1): update livox min range to 1.0m Feb 21, 2023
@yn-mrse yn-mrse merged commit d5deb74 into tier4/universe Feb 21, 2023
@yn-mrse yn-mrse deleted the feat/x1/update_livox_min_range_to_1.0m branch February 21, 2023 05:54
@tier4-autoware-public-bot
Copy link
Contributor

The backport to beta/v2022.05.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-beta/v2022.05.1 beta/v2022.05.1
# Navigate to the new working tree
cd .worktrees/backport-beta/v2022.05.1
# Create a new branch
git switch --create backport-107-to-beta/v2022.05.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d5deb74b39ba3a4e595e13e6fc8a6d0cc95718e4
# Push it to GitHub
git push --set-upstream origin backport-107-to-beta/v2022.05.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-beta/v2022.05.1

Then, create a pull request where the base branch is beta/v2022.05.1 and the compare/head branch is backport-107-to-beta/v2022.05.1.

tier4-autoware-public-bot bot pushed a commit that referenced this pull request Feb 21, 2023
* feat(x1): copy new_livox_horizon from common_sensor_launch

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1): remove dependency on common_sensor_launch

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1/livox): parameterize min_range to accommodate multiple hw variations

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1/livox): update livox min range to 1.0m

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

---------

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
(cherry picked from commit d5deb74)
yn-mrse added a commit that referenced this pull request Feb 21, 2023
feat(x1): update livox min range to 1.0m (#107)

* feat(x1): copy new_livox_horizon from common_sensor_launch

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1): remove dependency on common_sensor_launch

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1/livox): parameterize min_range to accommodate multiple hw variations

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat(x1/livox): update livox min range to 1.0m

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

---------

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
(cherry picked from commit d5deb74)

Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants