Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Make bourbon-neat a proper npm package #397

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Make bourbon-neat a proper npm package #397

merged 1 commit into from
Feb 19, 2016

Conversation

BlakeWilliams
Copy link
Contributor

When requiring bourbon-neat in Node it currently imports neat.scss.

This changes the entrypoint to index.js which exposes includePaths.
The includePaths can be passed to libsass which are used to resolve
@import declarations.

@tysongach tysongach mentioned this pull request Jan 18, 2016
Closed
@Lighttree
Copy link

Hi, when this pull request will be merged ? It would be nice to include Neat the same way as in Bourbon.

@colorful-tones
Copy link

+1

@gregrickaby
Copy link

Yeah, when trying to use bourbon-neat as an NPM package (with Gulp)...this error is thrown when running Sass.

../node_modules/bourbon-neat/app/assets/stylesheets/_neat.scss:7
@import "neat-helpers";
^

SyntaxError: Unexpected token ILLEGAL
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:404:25)
at Object.Module._extensions..js (module.js:432:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at Object. (/Applications/MAMP/htdocs/wd_s/Gulpfile.js:11:12)
at Module._compile (module.js:425:26)
at Object.Module._extensions..js (module.js:432:10)

The full Gulpfile.js for context.

Applying #397 fixes the error and allows me to compile without any issues! 😅

@gregrickaby gregrickaby mentioned this pull request Feb 10, 2016
Closed
11 tasks
@tysongach
Copy link
Contributor

👍

@BlakeWilliams
Make bourbon-neat a proper npm package
24f5eba 
When requiring `bourbon-neat` in Node it currently imports `neat.scss`.

This changes the entrypoint to `index.js` which exposes `includePaths`.
The `includePaths` can be passed to libsass which are used to resolve
`@import` declarations.
houndci-bot
houndci-bot reviewed Feb 19, 2016
View reviewed changes
index.js

module.exports = {
includePaths: [
path.join(__dirname, 'app/assets/stylesheets'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'__dirname' is not defined.

@BlakeWilliams BlakeWilliams deleted the bmw-npm-package branch February 19, 2016 16:31
@BlakeWilliams BlakeWilliams merged commit 24f5eba into master Feb 19, 2016
@fschroiff
Copy link

@BlakeWilliams When I install bourbon-neat from NPM I still get the old version currently.

@tysongach
Copy link
Contributor

@fschroiff This is only on master and hasn’t been released yet. Hoping to do that today.

@fschroiff
Copy link

@BlakeWilliams great! Thank you.

This was referenced Feb 27, 2016
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BlakeWilliams @Lighttree @colorful-tones @gregrickaby @tysongach @fschroiff @houndci-bot