-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gulp Integration #140
Comments
+1 for this! Hopefully in the process, it will fix our sourcemap issues. |
I've pushed up my initial Gulp set up in a feature branch. I'd love to have everyone play with it and post feedback here. Check it out! https://github.com/WebDevStudios/wd_s/tree/feature/gulp |
Super excited about this. I was going to move everything over to gulp too and poof, you did it for me :) Can't wait to play! |
I've been playing around for notifications and this is where I am currently. // Add to list
var notify= require('gulp-notify'); // Compile Sass and create stylesheet.
gulp.task('sass', function() {
return gulp.src('assets/sass/*.scss')
.pipe(sourcemaps.init())
.pipe(sass({
includePaths: neat,
outputStyle: 'expanded'
}))
.on('error', handleErrors)
.pipe(sourcemaps.write())
.pipe(gulp.dest('./'));
}); //Growl Notification for Errors
function handleErrors() {
var args = Array.prototype.slice.call(arguments);
notify.onError({
title: 'Compile Error',
message: '<%= error.message %>'
}).apply(this, args);
this.emit('end'); // Keeps it from hanging on the task
} |
I'm at a really good place with the Gulpfile. I feel like it's nearly development ready.
Changes: To test:
|
Makepot is working! Here is the link to the changes that I added: 6bc32df...be4e181 (updated) |
We may be able to use |
Update: Currently at a stand-still until thoughtbot/neat#397 is merged in. This will allow us to drop both Bourbon/Neat from Bower and use them as NPM packages instead. Growl notifications on error are still under development. Thanks to @allisonplus for helping me with that and @JPry for getting Makepot working. |
I added error handling monkey-patch with gulp-plumber, gulp-util, and gulp-notify. Tested, and works with failed Sass and JS compilations. Can't wait for Gulp 4.0 with error built in. 🦄 Associated commits: |
Putting this through it's paces on a personal client and I've found the following things:
|
Ok, all the above issues have been checked off (including all original requirements). I've spent the last hour trying to break it, and now everything is working as expected with these commits: 2aaf82b...e725806 IMHO: Gulp is ready to be merged in, as soon as thoughtbot/neat#397 is merged into https://github.com/thoughtbot/neat. Thanks to @allisonplus @colorful-tones @JPry and @efuller for all the help. ❤️ y'all! |
Good news! thoughtbot/neat#397 has been merged in. I'm told that they will have an update to NPM early next week. Once this drops, we'll be ready to merge this in. |
I've been dropping hints about this on the last couple of Designer calls. I spent the weekend playing with Gulp for a personal client, and I really quite like it. My goal is to set up wd_s with Gulp while retaining the workflow. Maybe it would even neat to offer both a Grunt and Gulp build options?
Will demo on the next call.
Todo:
Would also like to see examples of how others are using Gulp and their config files...
The text was updated successfully, but these errors were encountered: