Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in telnet service #321

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Fix regression in telnet service #321

merged 3 commits into from
Oct 31, 2023

Conversation

thinkst-francois
Copy link
Contributor

@thinkst-francois thinkst-francois commented Oct 30, 2023

Proposed changes

A regression in the telnet service occured where the Realm/portal required by AuthenticatingTelnetProtocol in twisted was removed.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

A regression in the telnet service occured where the Realm/portal
required by AuthenticatingTelnetProtocol in twisted was removed.
@thinkst-francois
Copy link
Contributor Author

Local tests:

2023-10-30T13:28:26+0000 [twisted.internet.protocol.ServerFactory#info] Starting factory <twisted.internet.protocol.ServerFactory object at 0x7feced277430>
{"dst_host": "192.168.5.157", "dst_port": 23, "honeycred": false, "local_time": "2023-10-30 13:28:33.402619", "local_time_adjusted": "2023-10-30 13:28:33.402648", "logdata": {"PASSWORD": "passworcd", "USERNAME": "admin"}, "logtype": 6001, "node_id": "opencanary-1", "src_host": "192.168.5.99", "src_port": 33128, "utc_time": "2023-10-30 13:28:33.402644"}
{"dst_host": "192.168.5.157", "dst_port": 23, "honeycred": true, "local_time": "2023-10-30 13:28:36.283700", "local_time_adjusted": "2023-10-30 13:28:36.283772", "logdata": {"PASSWORD": "password", "USERNAME": "admin"}, "logtype": 6001, "node_id": "opencanary-1", "src_host": "192.168.5.99", "src_port": 33128, "utc_time": "2023-10-30 13:28:36.283766"}

@thinkst-francois thinkst-francois merged commit 7cbcd03 into master Oct 31, 2023
34 checks passed
@thinkst-francois thinkst-francois deleted the telnet_auth_fix branch October 31, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v0.91 Seems to have problem with Telnet (Tested on Ubuntu 20.04 and 22.04)
2 participants