Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v0.91 Seems to have problem with Telnet (Tested on Ubuntu 20.04 and 22.04) #320

Closed
backlash-code opened this issue Oct 30, 2023 · 3 comments · Fixed by #321
Closed
Labels

Comments

@backlash-code
Copy link

backlash-code commented Oct 30, 2023

Opencanary looks to install and run, but no telnet service appears int the log, telnet port listens according to netstat but is not working when trying to connect. No response.

Error points to the twisted/conch/telnet.py module.

Expected maybe the newer python version to be the problem, but apparently not the issue.

Ubuntu 22.04 same result with 0.91
Ubuntu 20.04 same result with 0.91.

After a few attempts, installed a v0.90 on 20.04 - everything looks to be working normally, I assume 22.04 will work too with v0.90 - but haven't tested.

@Nenodema
Copy link

I encounter the same issue on Debian, I have some logs from the Docker container.

	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 902, in connectionMade
	builtins.TypeError: AuthenticatingTelnetProtocol.__init__() missing 1 required positional argument: 'portal'
2023-10-30T08:25:48+0000 [CanaryTelnetTransport,0,10.32.22.10] Unhandled Error
	  File "/opencanary/opencanary/modules/telnet.py", line 16, in dataReceived
	    TelnetTransport.dataReceived(self, data)
	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 556, in dataReceived
	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 627, in commandReceived
	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 644, in telnet_WILL
	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 648, in will_no_false
	  File "/usr/local/lib/python3.10/site-packages/twisted/conch/telnet.py", line 926, in enableRemote

@thinkst-francois
Copy link
Contributor

Hi @backlash-code
I quickly checked I can confirm it is broken with version 0.91.
The issue is twisted expecting a parameter portal in the init for AuthenticatingTelnetProtocol

@thinkst-francois thinkst-francois linked a pull request Oct 30, 2023 that will close this issue
9 tasks
@Nenodema
Copy link

Thanks @thinkst-francois I just tested your fix successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants