Introduce distinct markers for results with uncertain advancment #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Aug 2, 2024
Comment on lines
+216
to
+217
| # Assume best possible attempts for empty results and see who of | ||
| # the currently entered results would still qualify. |
There was a problem hiding this comment.
FTR we don't need to worry about results dropping out, because getting a better result than everybody is a "stronger assumption". Intuitively, when someone gets a better result than everybody they make 1 person not advance, but when they drop out they effectively make 0.75 person not advance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222. Also closes #128.
An ongoing round looks like this:
Ranks in the darker green "clinched advancement", while the ones in lighter green qualify as is, but may not advance depending on the remaining results.
I reverted #111 (ignoring empty results in percentage calculation), since those "uncertain" results will now show in the light color.
This change introduces an additional flag to results specifically for the display purpose, so it doesn't affect any of the existing logic.