Advancing when round is in progress: don't take the no-shows into account. Fixes #109 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Hey @Goosly! Thanks for following up on the issue, I just pushed some adjustments and this is good to go :)
|
I've tested this on an upcoming competition with mock results (then cleared the round afterwards) and it works as expected. Thank you for the extremely quick help @jonatanklosko ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear WST, @gregorbg , @jonatanklosko ,
The scenario is the following:
100 competitors registered for 3x3 round 1. 75% advance to the next round. My scoretakers enter results, and WCA Live shows 75 competitors advance to the next round, with the green label on their ranking. However, 5 people did not show up. My scoretakers remove those 5 people. Now, only 71 competitors advance to the next round. The competitors ranked 72nd, 73th, 74th and 75th are terribly disappointed because WCA Live tricked them into believing they were going to round 2.
This has been a returning issue at hundreds of competitions worldwide and yesterday, we had the same issue with one person thinking he was going to round 2 and then we had to remove him. One of the organizers then decided to give up his spot in round 2, so the other competitor could be added to round 2 instead.
This PR attempts to fix that. However, I don't know Euphoria and I did not setup anything locally to run the tests :-) So I hope you can help me if the tests are not working, or if I did anything else wrong. Thanks in advance for your time!