-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Updating runtime parameters #494
Conversation
TheiaProk_Illumina_PE_PHB - https://app.terra.bio/#workspaces/theiagen-training-workspaces/Theiagen_Lang_Sandbox/job_history/4fa24d88-2417-4fa3-a3e1-3f4268ca1198 realized I had to pass in flag to run midas- https://app.terra.bio/#workspaces/theiagen-training-workspaces/Theiagen_Lang_Sandbox/job_history/1fa8a187-17f8-4638-9ba3-965adb8e1c73 @jrotieno from my perspective, once you review your set of these workflows, you can mark it approved for merge |
For the additional TheiaProk tasks assigned to me, I just used Andrew Lang's runs: kSNP3 CPUs: |
@AndrewLangvt maybe you just need to mark the ones you went through as done on the board? |
@jrotieno good call; done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewLangvt and I have reviewed the changes and approve. Well done @sage-wright
This one is a doozy.
This PR:
🗑️ This dev branch should be deleted after merging to main.
🧠 Aim, Context and Functionality
Many tasks require far more runtime parameters than are actually used. This PR adjusts various runtime parameters accordingly.
🛠️ Impacted Workflows/Tasks & Changes Being Made
This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : No
Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No
📋 Workflow/Task Step Changes
🔄 Data Processing
Compute resources changed:
➡️ Inputs
None
⬅️ Outputs
None
🧪 Testing
Terra Testing
Suggested Scenarios for Reviewer to Test
Ensure costs and runtime attributes went down as expected.
Theiagen Version Release Testing (optional)
None
🔬 Final Developer Checklist
🎯 Reviewer Checklist
🗂️ Associated Documentation (to be completed by Theiagen developer)