Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Freyja_Dashboard] fix typo in freyja_dashboard output File variable name #482

Merged
merged 2 commits into from
May 28, 2024

Conversation

AndrewLangvt
Copy link
Contributor

This PR closes #422 .

🗑️ This dev branch should be deleted after merging to main.

🧠 Aim, Context and Functionality

This PR resolves a trivial spelling error in the outputs of freyja workflow, specifically the field denoting freyja dashboard

🛠️ Impacted Workflows/Tasks & Changes Being Made

This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : No

Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : No

📋 Workflow/Task Step Changes

🔄 Data Processing

Docker/software or software versions changed: No

Databases or database versions changed: No

Data processing/commands changed: No

File processing changed: No

Compute resources changed: No

➡️ Inputs

No Change

⬅️ Outputs

No change to output files. Trivial change to spelling of output namespace.

🧪 Testing

Test Dataset

Commandline Testing with MiniWDL or Cromwell (optional)

Locally tested via MiniWDL check.

Terra Testing

https://app.terra.bio/#workspaces/theiagen-training-workspaces/Theiagen_Lang_Sandbox/job_history/d48b5156-a4ee-4812-9756-72f99a674aef

Suggested Scenarios for Reviewer to Test

Theiagen Version Release Testing (optional)

🔬 Final Developer Checklist

  • The workflow/task has been tested locally and results, including file contents, are as anticipated
  • The workflow/task has been tested on Terra and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (to be completed by Theiagen developer)
  • Code changes follow the style guide

🎯 Reviewer Checklist

  • All impacted workflows/tasks have been tested on Terra with a different dataset than used for development
  • All reviewer-suggested scenarios have been tested and any additional
  • All changed results have been confirmed to be accurate
  • All workflows/tasks impacted by change/s have been tested using a standard validation dataset to ensure no unintended change of functionality
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments

🗂️ Associated Documentation (to be completed by Theiagen developer)

  • Relevant documentation on the Public Health Resources "PHB Main" has been updated
  • Workflow diagrams have been updated to reflect changes

@AndrewLangvt AndrewLangvt changed the title Al freyja spelling 422 [Freyja_Dashboard] fix typo in freyja_dashboard output File variable name May 23, 2024
@AndrewLangvt AndrewLangvt marked this pull request as ready for review May 23, 2024 15:38
@AndrewLangvt AndrewLangvt requested a review from sage-wright May 23, 2024 15:39
@sage-wright
Copy link
Member

Code changes look good 👍
Testing here, will merge upon success.

Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous work 🌟

@sage-wright sage-wright merged commit b5657de into main May 28, 2024
5 checks passed
@sage-wright sage-wright deleted the al-freyja-spelling-422 branch May 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Freyja_Dashboard] fix typo in freyja_dashboard output File variable name
2 participants