-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding assembly_mean_coverage
metrics for flu in TheiaCoV_Illumina_PE_PHB
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emily-smith1
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 38 influenza samples. Output in the assembly_mean_coverage column on Terra appears as expected with values for HA and NA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #313.
🗑️ This dev branch should be deleted after merging to main.
🧠 Aim, Context and Functionality
This PR adds the
assembly_mean_coverage
metrics for influenza HA and NA in theTheiaCoV_Illumina_PE_PHB
workflow which was previously only available for other pathogens.🛠️ Impacted Workflows/Tasks & Changes Being Made
This will affect the behavior of the workflow(s) even if users don’t change any workflow inputs relative to the last version : Yes (An output in
assembly_mean_coverage
where organism is "flu" that was previously empty)Running this workflow on different occasions could result in different results, e.g. due to use of a live database, "latest" docker image, or stochastic data processing : Yes (Though not as a result of this specific PR)
📋 Workflow/Task Step Changes
🔄 Data Processing
Docker/software or software versions changed: N/A
Databases or database versions changed: N/A
Data processing/commands changed:
The workflow now calls the assembly metric task when sample HA and/or NA bam files from IRMA are available.
File processing changed:
IRMA task now also outputs HA and NA bam files.
Compute resources changed: N/A
➡️ Inputs
Not changed
⬅️ Outputs
Now when
organism
is "flu", instead of the workflow returning an empty output forassembly_mean_coverage
, there will be a valueHA:<coverage>, NA:<coverage>
🧪 Testing
Test Dataset
A set of four samples were used:
Commandline Testing with MiniWDL or Cromwell (optional)
Local testing done for the IRMA task and works as expected.
Terra Testing
Testing done here: https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/Global_tree_testing/job_history/7189276f-f2b7-48be-b64d-3426353d087e
Suggested Scenarios for Reviewer to Test
Subtypes other than those listed here.
Theiagen Version Release Testing (optional)
🔬 Final Developer Checklist
🎯 Reviewer Checklist
🗂️ Associated Documentation (to be completed by Theiagen developer)