Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker to version tag 2.23.0-2024-01 #293

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

cimendes
Copy link
Member

@cimendes cimendes commented Jan 5, 2024

Closes #262

🛠️ Changes Being Made

Impacted Workflows/Tasks

All Theiaprok workflows

  • TheiaProk_Illumina_PE
  • TheiaProk_Illumina_SE
  • TheiaProk_ONT
  • TheiaProk_FASTA

🧠 Context and Rationale

This PR updates the mlst database sync with pubmlst as of January 2024

New docker container: us-docker.pkg.dev/general-theiagen/staphb/mlst:2.23.0-2024-01

📋 Workflow/Task Steps

N/A

Inputs

N/A

Outputs

N/A

Impacted Outputs

All mlst outputs

    File? ts_mlst_results = ts_mlst.ts_mlst_results
    String? ts_mlst_predicted_st = ts_mlst.ts_mlst_predicted_st
    String? ts_mlst_pubmlst_scheme = ts_mlst.ts_mlst_pubmlst_scheme
    String? ts_mlst_allelic_profile = ts_mlst.ts_mlst_allelic_profile
    String? ts_mlst_version = ts_mlst.ts_mlst_version
    File? ts_mlst_novel_alleles = ts_mlst.ts_mlst_novel_alleles
    String? ts_mlst_docker = ts_mlst.ts_mlst_docker

🧪 Testing

Locally

Local test passed with no issue on the mlst task

Terra

Underway

Scenarios for Reviewer to Test

All mlst calls are accurate with pubmlst database as of January 2024

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@cimendes cimendes added the enhancement This issue is a new feature or request label Jan 5, 2024
@cimendes cimendes marked this pull request as ready for review January 5, 2024 10:35
@kevinlibuit kevinlibuit self-requested a review January 7, 2024 18:48
@kevinlibuit
Copy link
Contributor

Thanks for the quick PR! Changes look great and this is ready for merging to main.

@kapsakcj wondering if we also want to mimic this practice for staphb images, i.e. creating mlst docker images with updated db. Hah, this conversation of docker-builds and dynamic databases continues!

@kapsakcj
Copy link
Contributor

kapsakcj commented Jan 8, 2024

@kapsakcj wondering if we also want to mimic this practice for staphb images, i.e. creating mlst docker images with updated db. Hah, this conversation of docker-builds and dynamic databases continues!

Yes, I think it would be good to update the mlst docker image on a schedule, perhaps once a month. Let's chat about this at the next staphb/docker-builds dev meeting

@cimendes cimendes merged commit d230cd0 into main Jan 8, 2024
@cimendes cimendes deleted the im-update-mlst-jan-24 branch January 8, 2024 18:15
@cimendes
Copy link
Member Author

cimendes commented Jan 9, 2024

The documentation has been updated to reflect this merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLST] Update MLST database for next release
3 participants