update default amrfinderplus docker image to v3.11.20 and db 2023-09-26.1 #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changes Being Made
updates default docker image for amrfinderplus to
us-docker.pkg.dev/general-theiagen/staphb/ncbi-amrfinderplus:3.11.20-2023-09-26.1
This is not the absolute latest version, but the more recent version 3.11.26 only adds a bug fix for a rare bug that does not affect our usage.
More importantly the database has not been updated since 2023-09-26, so we should be pretty up-to-date for the next few months
Impacted Workflows/Tasks
All TheiaProk workflows- ILMN PE, ILMN SE, ONT, FASTA
Standalone amrfinderplus workflow
🧠 Context and Rationale
📋 Workflow/Task Steps
N/A
Inputs
N/A
Outputs
N/A
Impacted Outputs
All outputs will be impacted as results may differ slightly due to database differences
🧪 Testing
Locally
Task ran successfully with
miniwdl
Terra
Will add links when testing is completeScenarios for Reviewer to Test
Good to test a variety of different species to try to trigger all of the
--organism
flag inputs. I have a dataset for doing this with ILMN PE, ILMN SE, and FASTAMy ONT dataset is not comprehensive, it only has a few klebsiella's
🔬 Quality checks
Pull Request (PR) checklist: