Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default amrfinderplus docker image to v3.11.20 and db 2023-09-26.1 #229

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

kapsakcj
Copy link
Contributor

@kapsakcj kapsakcj commented Oct 24, 2023

🛠️ Changes Being Made

updates default docker image for amrfinderplus to us-docker.pkg.dev/general-theiagen/staphb/ncbi-amrfinderplus:3.11.20-2023-09-26.1

This is not the absolute latest version, but the more recent version 3.11.26 only adds a bug fix for a rare bug that does not affect our usage.

More importantly the database has not been updated since 2023-09-26, so we should be pretty up-to-date for the next few months

Impacted Workflows/Tasks

All TheiaProk workflows- ILMN PE, ILMN SE, ONT, FASTA

Standalone amrfinderplus workflow

🧠 Context and Rationale

📋 Workflow/Task Steps

N/A

Inputs

N/A

Outputs

N/A

Impacted Outputs

All outputs will be impacted as results may differ slightly due to database differences

🧪 Testing

Locally

Task ran successfully with miniwdl

Terra

Will add links when testing is complete

Scenarios for Reviewer to Test

Good to test a variety of different species to try to trigger all of the --organism flag inputs. I have a dataset for doing this with ILMN PE, ILMN SE, and FASTA

My ONT dataset is not comprehensive, it only has a few klebsiella's

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@kapsakcj kapsakcj marked this pull request as ready for review October 24, 2023 15:06
@kapsakcj
Copy link
Contributor Author

Testing in Terra is complete and this PR is ready for review.

Happy to share test datasets with whomever is reviewing, but please throw any and all bacterial samples through the impacted workflows

@frankambrosio3 frankambrosio3 self-requested a review November 3, 2023 13:27
Copy link
Contributor

@frankambrosio3 frankambrosio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankambrosio3 frankambrosio3 merged commit 5fc24ee into main Nov 3, 2023
@kapsakcj kapsakcj deleted the cjk-update-amrfinderplus-default branch November 3, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants