Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults #171

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Update defaults #171

merged 9 commits into from
Aug 28, 2023

Conversation

sage-wright
Copy link
Member

@sage-wright sage-wright commented Aug 24, 2023

Update default docker images and updates the version

πŸ› οΈ Changes Being Made

🧠 Context and Rationale

πŸ“‹ Workflow/Task Steps

Inputs

Outputs

πŸ§ͺ Testing

Locally

Terra

πŸ”¬ Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@sage-wright sage-wright requested a review from cimendes August 28, 2023 14:01
@cimendes
Copy link
Member

cimendes commented Aug 28, 2023

Test TheiaCov_Illumina_PE_PHB

Commit id: 719cca0

9 SC2 samples with multiple lineages on dev branch: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/39ac8548-0279-4442-ab69-d88cc60009f9

9 SC2 samples with multiple lineages on main branch: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/96576998-e974-4390-b209-cfcb83eb929b

βœ… No change in columns
βœ… column content reflects the new changes (assembly method correctly states PHB v1.1.0, as well as nextclade tag, pangolin docker)

@cimendes
Copy link
Member

cimendes commented Aug 28, 2023

@cimendes cimendes merged commit 683c84c into main Aug 28, 2023
@cimendes cimendes deleted the smw-version-dev branch August 28, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants