Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .fixtures.yml style #229

Merged
merged 1 commit into from
May 4, 2023
Merged

Clean up .fixtures.yml style #229

merged 1 commit into from
May 4, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 25, 2023

Drops the Puppet < 6 compatibility, which is no longer needed. It also applies a consistent formatting.

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran bundle exec rake spec_prep and then tried running the acceptance tests. I'm seeing:

  Error: /Stage[main]/Candlepin::Config/Concat[/etc/candlepin/candlepin.conf]/Concat_file[/etc/candlepin/candlepin.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x0000000003ddf038>

and later

  Error: /Stage[main]/Postgresql::Server::Config/Postgresql::Server::Instance::Config[main]/Concat[/var/lib/pgsql/data/pg_hba.conf]/Concat_file[/var/lib/pgsql/data/pg_hba.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x00000000045a2248>
  Did you mean?  flat_map
  Error: /Stage[main]/Postgresql::Server::Config/Postgresql::Server::Instance::Config[main]/Concat[/var/lib/pgsql/data/pg_ident.conf]/Concat_file[/var/lib/pgsql/data/pg_ident.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x00000000047934d0>

This seems due to the same underlying issue as puppetlabs/puppetlabs-concat#771

Can you pin it so that we are using a compatible version?

@ekohl
Copy link
Member Author

ekohl commented Apr 25, 2023

Can you pin it so that we are using a compatible version?

I've been thinking of going the other direction: drop Puppet 6 and Ruby < 2.7. It's surprising to me that the Ruby 2.5 unit tests pass.

I do wonder why the Puppet 7 tests are also failing.

@wbclark
Copy link
Contributor

wbclark commented Apr 26, 2023

@ekohl how can I set the puppet version to use when testing with https://github.com/voxpupuli/beaker-vagrant ?

@ekohl
Copy link
Member Author

ekohl commented Apr 26, 2023

Oh yes, we should really update this line:
https://github.com/voxpupuli/voxpupuli-acceptance/blob/e1f5ad4eaedf10acc21b47c26045afe33c5c9c42/lib/voxpupuli/acceptance/spec_helper_acceptance.rb#L5

So set the env var BEAKER_PUPPET_COLLECTION to puppet7 and that should work.

This drops the Puppet < 6 compatibility, which is no longer needed. It
also applies a consistent formatting
@ekohl ekohl changed the title Add puppet/systemd as a fixture & clean up fixtures Clean up .fixtures.yml style May 3, 2023
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe to merge despite the Puppet 6 failure

@ekohl ekohl merged commit 9afe265 into theforeman:master May 4, 2023
@ekohl ekohl deleted the fixtures branch May 4, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants