-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up .fixtures.yml style #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran bundle exec rake spec_prep
and then tried running the acceptance tests. I'm seeing:
Error: /Stage[main]/Candlepin::Config/Concat[/etc/candlepin/candlepin.conf]/Concat_file[/etc/candlepin/candlepin.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x0000000003ddf038>
and later
Error: /Stage[main]/Postgresql::Server::Config/Postgresql::Server::Instance::Config[main]/Concat[/var/lib/pgsql/data/pg_hba.conf]/Concat_file[/var/lib/pgsql/data/pg_hba.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x00000000045a2248>
Did you mean? flat_map
Error: /Stage[main]/Postgresql::Server::Config/Postgresql::Server::Instance::Config[main]/Concat[/var/lib/pgsql/data/pg_ident.conf]/Concat_file[/var/lib/pgsql/data/pg_ident.conf]: Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #<Array:0x00000000047934d0>
This seems due to the same underlying issue as puppetlabs/puppetlabs-concat#771
Can you pin it so that we are using a compatible version?
I've been thinking of going the other direction: drop Puppet 6 and Ruby < 2.7. It's surprising to me that the Ruby 2.5 unit tests pass. I do wonder why the Puppet 7 tests are also failing. |
@ekohl how can I set the puppet version to use when testing with https://github.com/voxpupuli/beaker-vagrant ? |
Oh yes, we should really update this line: So set the env var |
This drops the Puppet < 6 compatibility, which is no longer needed. It also applies a consistent formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is safe to merge despite the Puppet 6 failure
Drops the Puppet < 6 compatibility, which is no longer needed. It also applies a consistent formatting.