Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat v8 breaks apache v5.6.0 #771

Closed
jcwarp opened this issue Apr 12, 2023 · 6 comments
Closed

Concat v8 breaks apache v5.6.0 #771

jcwarp opened this issue Apr 12, 2023 · 6 comments

Comments

@jcwarp
Copy link

jcwarp commented Apr 12, 2023

Just FYI, using the newest concat breaks the old apache code:

Failed to generate additional resources using 'eval_generate': undefined method `filter_map' for #Array:0x0000000003db80c8
Did you mean? flat_map
Source:/Stage[main]/Apache/Apache::Vhost[default-ssl]/Concat[15-default-ssl.conf]/Concat_file[15-default-ssl.conf]File:/etc/puppetlabs/code/environments/production/modules/concat/manifests/init.ppLine:157
2023-04-1216:26 Z | err |  

@LukasAud
Copy link
Contributor

Hi @jcwarp, thanks for reporting this issue. Our Puppet 8 support update has bumped the expected minimum ruby version from 2.5 (our previous minimum while Puppet 6 was supported) to 2.7 (the required minimum to run on Puppet 7). This change has translated into a series of Rubocop updates, including the usage of .filter_map (introduced in Ruby 2.7) instead of .map().compact.

We are currently working on updating all modules to drop support for Puppet 6 and introduce it for Puppet 8, including Apache. Unfortunately, that means this issue doesn't really have a fix. If you want to resume normal operations, you can update to Puppet 7, or pin the concat module to the previous version and wait for Puppet 8 support for Apache to be released as well, then upgrade directly to our latest Puppet agent.

Sorry for the inconvenience.

@saz
Copy link

saz commented Apr 15, 2023

@LukasAud So... v8 of this module is dropping support for Puppet 6? Sounds like a change which should have been reflected in the changelog.

@LukasAud
Copy link
Contributor

LukasAud commented Apr 17, 2023

@saz That is actually correct. It seems like a mistake was made during the naming of this (and some other) modules PRs. We will be addressing them asap. For now, #773 has been created to address concat.

@alexjfisher
Copy link
Contributor

Fixed in #776

@LukasAud
Copy link
Contributor

Hey @jcwarp, it looks like this issue was addressed. Can you confirm that this issue has been resolved on your end and, if so, close this issue?

@jcwarp
Copy link
Author

jcwarp commented May 10, 2023

The issue was fixed!
Thanks everyone!

@jcwarp jcwarp closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants