Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional disk size and device number issue #78

Closed
pdzionek opened this issue Apr 30, 2019 · 4 comments
Closed

Additional disk size and device number issue #78

pdzionek opened this issue Apr 30, 2019 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@pdzionek
Copy link

Describe the bug
While you are creating a new vm, and you add additional disks it is not possible to change their size and device id with up and down arrows. You can only do it by typing. It doesn't apply to default disk, for which you can use these up/down arrows.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'All Host -> Create Host'
  2. While you are on Host Tab, choose deploy on 'Proxmox Node'
  3. Switch to 'Virtual Machine tab'
  4. Go to disk section and add another disk/disks
  5. Try clicking up/down arrows for device id and size

Expected behavior
Up and Down arrows should work for added disks

Screenshots
unresponsive1

Desktop (please complete the following information):

  • OS: Xubuntu 18.04
  • Browser Firefox
  • Version 66.0.3

Foreman - Proxmox versions
foreman 1.21.3-1
ruby-foreman-fog-proxmox 0.6.0-1
Proxmox cluster 5.3.7

@pdzionek pdzionek changed the title Adding additional disk size and device number issue Additional disk size and device number issue Apr 30, 2019
@tristanrobert
Copy link
Collaborator

I have tested with 0.7.0 and Foreman 1.22 and 1.23. It is already fixed. The only issue that remains is minimum to 1 and not 0: https://projects.theforeman.org/issues/25111

@pdzionek
Copy link
Author

Ok, I will check it out, as soon as, foreman releases 1.22 as stable version.

@tristanrobert
Copy link
Collaborator

tristanrobert commented Apr 30, 2019

But you are right, the spinner still does not work when you just add a disk. I think it is an issue from foreman when a spinner is included in a removable_layout form: https://projects.theforeman.org/issues/26713

@tristanrobert tristanrobert added the bug Something isn't working label Apr 30, 2019
@tristanrobert tristanrobert added this to the Not planned milestone Apr 30, 2019
@tristanrobert tristanrobert modified the milestones: Not planned, 0.8.1 Nov 5, 2019
@tristanrobert tristanrobert reopened this Nov 5, 2019
tristanrobert added a commit that referenced this issue Nov 7, 2019
@m-bucher
Copy link
Contributor

m-bucher commented Nov 8, 2019

foreman issue is fixed in 1.24: theforeman/foreman#7057

hlawatschek pushed a commit to ATIX-AG/foreman_fog_proxmox that referenced this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants