Fixes #27903 - Do not init template-form-elements

[m-bucher]

fixes problem with not initialized counter and byte-size input elements
within dynamically added volumes of compute-resources in host-create

This fixed the error for me on https://github.com/theforeman/foreman_fog_proxmox, but I am open for better solutions 😉

[theforeman-bot]

@m-bucher, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

• check #27902: ui-spinner does not work when used for volume-templates in compute resource is the correct one
• move ticket #27902 from Katello to the Foreman project
• or file a new ticket in the Foreman project

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).

---

This message was auto-generated by Foreman's prprocessor

[theforeman-bot]

Issues: #27902

[ezr-ondrej]

Looks good overall @m-bucher, I agree this probably should go in (I would only like to make sure, we are not depending on the form_template to be initialized somewhere, but I wouldn't guess so.
The problem you are facing seems similar to one, that has been fixed in #7023 though, could you try if that patch fixes your problem?

[ezr-ondrej]

[test katello]

[ezr-ondrej]

[test foreman]

[m-bucher]

@ezr-ondrej , just tried the patch, but it did not fix the broken spinner-elements.

I agree, we should make sure that this does not break anything.
From what I saw (using git grep), counter_f and byte_size_f elements are only used for not-templated forms in foreman. So I guess we are save there.
I would have liked to add an implementation that uses byte_size_f to set disk-size in libvirt-volumes, which is currently just an input-field (probably because the spinners would not work 😉 ), but I am short on spare time at the moment.

However, I do not know if other plugins use these elements in form-templates.

[ezr-ondrej]

Works and the implementation make sense, only the argument check is bit tricky. Could we improve it a bit?

[ezr-ondrej]

The implementation looks good already, thanks for the event handling, looks better now!
Just one idea I came up with - bit more readable implementation of the parent checking. Let me know if you want to use it, if not, I am ok to merge as is :)

[ezr-ondrej]

I believe that with this:

Suggested change

	$('input.byte_spinner', selection).each(function() {
	$('input.byte_spinner, selection).not('.form_template input.byte_spinner').each(function() {
	// ....

we could leave out the if.

[m-bucher]

Nice, I just added it.
eslint thinks the lines are too long, so it resulted in some code reformatting.

[ezr-ondrej]

Thanks @m-bucher 👍 good job with the JS fight! 😍 👏