[PHP 8.4] Fixes for implicit nullability deprecation

[Ayesh]

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:

• RFC
• PHP 8.4: Implicitly nullable parameter declarations deprecated

The changes are modified on the generated files. This PR is merely to show the diffs.

[staabm]

just came here to submit a similar PR. would be great to have this one merged :-)

[ophian]

me too... 😅 I should have had a look earlier and it would have saved me an hour of work... (I did this to get rid of the deprecations in PhpMyAdmin)

[shish]

This is my current attempt at updating the generator to handle this case:

--- a/generator/src/Parameter.php
+++ b/generator/src/Parameter.php
@@ -75,7 +75,7 @@ class Parameter

     public function isNullable(): bool
     {
-        return $this->phpStanType->isNullable();
+        return $this->phpStanType->isNullable() || $this->getDefaultValue() === "null";
     }

     /*
diff --git a/generator/src/WritePhpFunction.php b/generator/src/WritePhpFunction.php
index d0775fb..ed4f11a 100644
--- a/generator/src/WritePhpFunction.php
+++ b/generator/src/WritePhpFunction.php
@@ -143,6 +143,9 @@ class WritePhpFunction
             }

             if ($paramAsString !== '') {
+                if ($param->isNullable() && $paramAsString[0] !== "?") {
+                    $paramAsString = "?" . $paramAsString;
+                }
                 $paramAsString .= ' ';
             }

[shish]

I needed this for my own use, and I don't see it getting merged any time soon, so I've fixed this (and merged a bunch of the other open PRs) and released as shish/safe (flagged as a replacement package so it should be drop-in compatible)

[duncanmcclean]

PHP 8.4 has been released and will be announced today. Is there anything we can do to help get this merged?

[shish]

Given that there are still php8.0 fixes waiting to be merged, I think your best hope of php8.4 support is switching over to a not-abandoned fork

[mfn]

I've tested shish/safe and can confirm "it just works" as a drop-in.

However, it does not work together with https://github.com/thecodingmachine/phpstan-safe-rule because that one has (understandably, I guess) hard-coded logic to locate thecodingmachine/safe and read the function list from it, etc. You just get errors from phpstan.
(On top of that, phpstan-safe-rule at some point also needs to be adapted to work with PHPStan 2)

In the past I was involved with https://github.com/PHP-Open-Source-Saver , we forked over https://github.com/PHP-Open-Source-Saver/jwt-auth and try to be active/maintain it there. A few other forks also found their home there.

If we've enough interested ppl, I'm happy to join a group there who wants to have a more joint-maintained version (incl. a proper generator fix etc.).

[shish]

However, it does not work together with https://github.com/thecodingmachine/phpstan-safe-rule because that one has (understandably, I guess) hard-coded logic to locate thecodingmachine/safe and read the function list from it, etc. You just get errors from phpstan.

That is correct, I ended up forking that too - https://github.com/shish/phpstan-safe-rule/

[BafS]

@Kharhamel @moufmouf would it be possible to merge this PR please?

[danepowell]

shish/safe isn't a drop-in replacement for all projects, as it bumps the minimum PHP version from 8.0 to 8.2.

@shish can you please at least support 8.1, which has security support for another year? My project depends on the safe library and has to support PHP 8.1 for compliance reasons.

[shish]

Heads up that the original maintainers have returned from hibernation in #452 and are looking at merging my updates upstream \o/

As to php8.1 support, that is harder than it looks because php's standard library has backwards-incompatible changes at the syntax level - but I have flagged that as something for the new maintenance team to discuss and decide on before they put out a new version

[staabm]

@shish @OskarStark @silasjoisten I think this PR here is a no-brainer and should be merged right away.

it doesn't impact BC was already confirmed by people in here to be working.

we should just open a corrsponding issue at the phpstan-safe-rule so we don't forget about reflecting the changes there.

agree?

[OskarStark]

I agree 👍 Feel free to merge it

[shish]

IIRC (I'm still travelling and away from laptop) this PR doesn't actually fix the issue with generating incompatible code - it manually edits the auto-generated files, but as soon as somebody runs the generator again, they will go back to being broken

[staabm]

@Ayesh picked your changes into #464 and closing here

thank you

[staabm]

@shish @OskarStark @silasjoisten I will work thru all open PRs and merge what I can do so we can move forward.

I don't it makes much sense that we look with 4 people above anything.
Feel free to disagree and start a discussion in case you don't like that. I want this things to be done right now, so I am moving ahead for now.

after we got everything sorted we should have a more organized process ;)

[OskarStark]

Thanks, go ahead, happy to help, but also quite busy right now with @silasjoisten 👍