Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php8.4 support #1224

Merged
merged 1 commit into from
Sep 11, 2024
Merged

php8.4 support #1224

merged 1 commit into from
Sep 11, 2024

Conversation

shish
Copy link
Owner

@shish shish commented Aug 31, 2024

php8.4 support

@shish shish force-pushed the pr1224 branch 2 times, most recently from b0d0422 to 078328c Compare August 31, 2024 23:38
@shish shish marked this pull request as draft August 31, 2024 23:39
@shish
Copy link
Owner Author

shish commented Sep 5, 2024

Tests are now passing, but flooding the logs with deprecation warnings from the Safe library

@shish
Copy link
Owner Author

shish commented Sep 9, 2024

Tracking the warnings in upstream: thecodingmachine/safe#441

@shish shish force-pushed the pr1224 branch 5 times, most recently from d28ecec to 62a5196 Compare September 10, 2024 13:26
@shish shish marked this pull request as ready for review September 11, 2024 02:24
@shish
Copy link
Owner Author

shish commented Sep 11, 2024

Looks like I'm maintaining Safe myself now 🤷

@shish shish merged commit 88229fa into main Sep 11, 2024
30 checks passed
@shish shish deleted the pr1224 branch September 11, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shish