Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bat43 support #541

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Add bat43 support #541

merged 6 commits into from
Feb 10, 2021

Conversation

yfuku
Copy link
Contributor

@yfuku yfuku commented Jan 30, 2021

Description

QMK Pull Request

qmk/qmk_firmware#11729

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yfuku yfuku changed the title Topic via for bat43 Add bat43 support Jan 30, 2021
@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Jan 31, 2021
@yfuku
Copy link
Contributor Author

yfuku commented Feb 8, 2021

My PR to QMK has been accepted, the board is in the QMK master now.

@wilba wilba merged commit 5aa8df4 into the-via:master Feb 10, 2021
@yfuku yfuku deleted the topic_via_for_bat43 branch February 10, 2021 01:16
@yfuku
Copy link
Contributor Author

yfuku commented Feb 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfuku @wilba