Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

via support for bat43 #11729

Merged
merged 2 commits into from
Feb 7, 2021
Merged

via support for bat43 #11729

merged 2 commits into from
Feb 7, 2021

Conversation

yfuku
Copy link
Contributor

@yfuku yfuku commented Jan 30, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 30, 2021
@yfuku yfuku mentioned this pull request Jan 30, 2021
Merged
6 tasks
@yfuku
Copy link
Contributor Author

yfuku commented Feb 5, 2021

@drashna Thanks for the review.
I'm sorry, I forgot.
I've added one more layer.

drashna
drashna approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. It's something that can be easily overlooked!

@zvecr zvecr merged commit 7e82879 into qmk:master Feb 7, 2021
flarestarwingz pushed a commit to flarestarwingz/qmk_firmware that referenced this pull request Feb 8, 2021
@yfuku @flarestarwingz
via support for bat43 (qmk#11729)
425e820 
* via support for bat43

* add adjust layer for via
@yfuku
Copy link
Contributor Author

yfuku commented Feb 10, 2021

Thanks!

sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
@yfuku @sowbug
via support for bat43 (qmk#11729)
550688f 
* via support for bat43

* add adjust layer for via
@yfuku yfuku deleted the topic_bat43_via branch February 12, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yfuku @drashna @zvecr