fsapi: adds Oflag to decouple from syscall package #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| type readFS struct { | ||
| fs fsapi.FS | ||
| fsapi.FS |
There was a problem hiding this comment.
changed like this to stop tedious forward-wrapping
This adds `fsapi.Oflag` which includes oflag values needed to support `fsapi.FS`. Notably, this covers more area than Go does. Go defines portable abstractions for most open flags, but not all. Flags like `O_DIRECTORY` are needed by wasip1 and not defined in Go as `os.O_DIRECTORY`. Also, some operating systems don't define these either. Instead we have a new `fsapi.Oflag` type which includes all flags needed, even if notably in windows behavior is emulated. Signed-off-by: Adrian Cole <adrian@tetrate.io>
| // flags can coexist bitwise. | ||
| // - This is like `flag` in os.OpenFile and `oflag` in POSIX. See | ||
| // https://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html | ||
| type Oflag uint32 |
There was a problem hiding this comment.
here is the new type
evacchi
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
fsapi.Oflagwhich includes oflag values needed to supportfsapi.FS. Notably, this covers more area than Go does. Go defines portable abstractions for most open flags, but not all. Flags likeO_DIRECTORYare needed by wasip1 and not defined in Go asos.O_DIRECTORY. Also, some operating systems don't define these either. Instead we have a newfsapi.Oflagtype which includes all flags needed, even if notably in windows behavior is emulated.