Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: add WASI FS constants for wasip1 and plan9 #1585

Closed
wants to merge 1 commit into from
Closed

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Jul 17, 2023

add some missing constants to improve cross-platform build support

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@mathetake
Copy link
Member

wanna add plan9 to https://github.com/tetratelabs/wazero/blob/main/Makefile#L211-L230 at least for testing?

@codefromthecrypt
Copy link
Contributor

right now I think it is a bit confusing in our docs to have partially os.O_ flags, partially syscall.O_ flags and partially package scoped ones. I had a WIP locally to define them all.. all the ones we accept. as it is less messy (though agree this could get things to compile). Either way I don't think we should add plan 9 constants until the whole thing can compile (GOOS=plan9 in the Makefile like the others)

@codefromthecrypt
Copy link
Contributor

#1586 takes a different approach. When we later solve plan9 we can add constants for its oflags here. However, let's first finish decoupling from syscall first. Once that's done, plan9 can be solved for all things not just oflag.

@evacchi evacchi closed this Jul 19, 2023
@evacchi evacchi deleted the constants branch July 19, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants