-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2etests-cli: Add PNG test #963
Conversation
Closes terrastruct#903 Closes terrastruct#918
1fef587
to
9227021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u add a test with flag just to demo too? like different pad
or something.
maybe a multi-board one too? to show how that'd work
i wonder why this png looks blurry. are you on latest d2 or release d2?
This uses my xmain PR to run d2 in memory as though it's running externally. So it's the same commit which was just rebased on master. |
Oh haha looks like I didn't run with |
actually the blurry png was last release, so it should've sorted itself. weiiiird. let me try pulling and running and seeing if i get a different PNG than u after u run with TA=1 |
PNGs aren't blurry for me after I ran with |
Fixed ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe u need to install dependencies differently like this guy: #744 (comment) |
202b6cf
to
ff0aa99
Compare
ff0aa99
to
8bf6c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to disable d2renderer sketch tests too then? You can just push a commit after to make it work on arm64 and I'll remember to not touch. |
no those don't compare diffs remember, they just output it so that the visual changes are shown in PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so good to have these, covering a huge blind spot for d2. i'm sure many bugs will be found as we populate these tests. 💯
f4f02da
to
86de922
Compare
PNG renders seem to work intermittently on github actions so whatever. If we're ignoring the diffs we might as well not even run these on CI.
Closes #903
Closes #918